Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 323153002: Update WeakPtr documentation for SequencedTaskRunner support. (Closed)

Created:
6 years, 6 months ago by davidben
Modified:
6 years, 2 months ago
Reviewers:
Mark Mentovai, brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

Update WeakPtr documentation for SequencedTaskRunner support. WeakPtr supported SequencedTaskRunner in https://codereview.chromium.org/20754006, but the documentation was not updated to match. BUG=none Committed: https://crrev.com/e58877edb51b0a0835019246ceb57fd4f2d5cbfc Cr-Commit-Position: refs/heads/master@{#300717}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M base/memory/weak_ptr.h View 1 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
davidben
There was some question as to whether base::WeakPtr supported SequencedTaskRunners. Apparently the answer is yes ...
6 years, 6 months ago (2014-06-10 19:02:27 UTC) #1
davidben
Apparently I still have this sitting around. +mark since base/OWNERS changed.
6 years, 2 months ago (2014-10-21 22:36:55 UTC) #3
Mark Mentovai
LGTM
6 years, 2 months ago (2014-10-22 13:25:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/323153002/20001
6 years, 2 months ago (2014-10-22 14:33:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/5156)
6 years, 2 months ago (2014-10-22 15:18:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/323153002/20001
6 years, 2 months ago (2014-10-22 16:24:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/3621)
6 years, 2 months ago (2014-10-22 16:43:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/323153002/20001
6 years, 2 months ago (2014-10-22 17:01:34 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 18:37:18 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:38:14 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e58877edb51b0a0835019246ceb57fd4f2d5cbfc
Cr-Commit-Position: refs/heads/master@{#300717}

Powered by Google App Engine
This is Rietveld 408576698