Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20754006: base: Re-re-apply WeakPtr support for SequencedWorkerPools (Closed)

Created:
7 years, 4 months ago by tommycli
Modified:
7 years, 4 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), sadrul, amit, gavinp+memory_chromium.org, dcaiafa+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, erikwright+watch_chromium.org, bruening+watch_chromium.org, wez+watch_chromium.org, sanjeevr, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, Lei Zhang, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, Greg Billock, alexeypa+watch_chromium.org, glider+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

base: Re-re-apply WeakPtr support for SequencedWorkerPools This is a continuation of https://codereview.chromium.org/20163004/#ps55001 and identical to Patchset 4. I'm adding back some death test threadsafe flags that got dropped from the re-apply. In other words, this CL is: https://codereview.chromium.org/20163004/#ps55001 + https://codereview.chromium.org/19617002/ Feel free to revert if it causes issues again. TBR=akalin,darin,dewittj,rnk BUG=165590 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -296 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/weak_ptr.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/memory/weak_ptr.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M base/message_loop/message_pump_io_ios.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/sequence_checker.h View 3 chunks +2 lines, -14 lines 0 comments Download
M base/sequence_checker_impl.h View 1 chunk +18 lines, -24 lines 0 comments Download
M base/sequence_checker_impl.cc View 1 chunk +27 lines, -12 lines 0 comments Download
D base/sequence_checker_impl_unittest.cc View 1 chunk +0 lines, -218 lines 0 comments Download
M base/sequence_checker_unittest.cc View 1 chunk +324 lines, -14 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/audio_capturer_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/base_unittests.gtest.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/20754006/1
7 years, 4 months ago (2013-07-26 20:58:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/20754006/1
7 years, 4 months ago (2013-07-26 21:49:29 UTC) #2
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=63858
7 years, 4 months ago (2013-07-28 00:12:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/20754006/1
7 years, 4 months ago (2013-07-29 15:14:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/20754006/1
7 years, 4 months ago (2013-07-30 03:56:57 UTC) #5
akalin
On 2013/07/30 03:56:57, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 4 months ago (2013-07-30 04:22:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/20754006/1
7 years, 4 months ago (2013-07-30 15:43:42 UTC) #7
tommycli
7 years, 4 months ago (2013-07-30 19:26:45 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 manually as r214411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698