Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 323123004: Replace compile time guard with runtime flag in blink and remove ENABLE_FAST_MOBILE_SCROLLING in gy… (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
Avi (use Gerrit), blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., piman, rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Replace compile time guard with runtime flag in blink and remove ENABLE_FAST_MOBILE_SCROLLING in gyp file. The effort needs to be done in 3 steps: 1. Create the runtime flag interface in blink; 2. Enable the flag for Android from chromium even it does not do anything in blink; 3. Replace compile time guard with runtime flag in blink and remove ENABLE_FAST_MOBILE_SCROLLING in gyp file. This is the 3rd set of changes. BUG=381391 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175967

Patch Set 1 #

Patch Set 2 : Fix gni file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M Source/build/features.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/config.gni View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
c.shu
6 years, 6 months ago (2014-06-10 19:32:35 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-10 23:02:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/323123004/20001
6 years, 6 months ago (2014-06-10 23:03:47 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-10 23:08:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 23:11:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7416)
6 years, 6 months ago (2014-06-10 23:11:16 UTC) #6
tkent
Source/config.gni needs top-level owners.
6 years, 6 months ago (2014-06-10 23:21:25 UTC) #7
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-11 17:33:56 UTC) #8
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-11 17:34:11 UTC) #9
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-11 17:34:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/323123004/20001
6 years, 6 months ago (2014-06-11 17:35:08 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 17:39:01 UTC) #12
Message was sent while issue was closed.
Change committed as 175967

Powered by Google App Engine
This is Rietveld 408576698