Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 323093007: Clean up interface to media gallery list entry view (Closed)

Created:
6 years, 6 months ago by vandebo (ex-Chrome)
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Visibility:
Public.

Description

Clean up interface to media gallery list entry view BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -31 lines) Patch
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_gallery_list_entry_view.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_gallery_list_entry_view.mm View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
vandebo (ex-Chrome)
6 years, 6 months ago (2014-06-10 21:01:45 UTC) #1
Lei Zhang
lgtm
6 years, 6 months ago (2014-06-10 21:09:20 UTC) #2
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-10 21:11:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/323093007/1
6 years, 6 months ago (2014-06-10 21:12:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 03:04:22 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 04:28:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/161447)
6 years, 6 months ago (2014-06-11 04:28:53 UTC) #7
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-11 15:49:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/323093007/1
6 years, 6 months ago (2014-06-11 15:51:29 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 20:03:20 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 20:19:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26053)
6 years, 6 months ago (2014-06-11 20:19:56 UTC) #12
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-11 20:32:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/323093007/1
6 years, 6 months ago (2014-06-11 20:35:58 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:21:27 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:36:52 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26143)
6 years, 6 months ago (2014-06-11 21:36:53 UTC) #17
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-11 21:39:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/323093007/1
6 years, 6 months ago (2014-06-11 21:41:26 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:22:43 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:25:06 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26231)
6 years, 6 months ago (2014-06-11 22:25:07 UTC) #22
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-11 23:01:05 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/323093007/1
6 years, 6 months ago (2014-06-11 23:03:20 UTC) #24
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 23:06:01 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 23:16:02 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26295)
6 years, 6 months ago (2014-06-11 23:16:03 UTC) #27
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-12 23:53:25 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/323093007/1
6 years, 6 months ago (2014-06-12 23:55:09 UTC) #29
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 02:18:21 UTC) #30
Message was sent while issue was closed. 
Change committed as 276885

Powered by Google App Engine
This is Rietveld 408576698