Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Side by Side Diff: chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc

Issue 323093007: Clean up interface to media gallery list entry view (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h" 5 #include "chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h"
6 6
7 #include "chrome/browser/media_galleries/media_galleries_preferences.h"
7 #include "grit/generated_resources.h" 8 #include "grit/generated_resources.h"
8 #include "grit/theme_resources.h" 9 #include "grit/theme_resources.h"
9 #include "third_party/skia/include/core/SkColor.h" 10 #include "third_party/skia/include/core/SkColor.h"
10 #include "ui/base/l10n/l10n_util.h" 11 #include "ui/base/l10n/l10n_util.h"
11 #include "ui/base/resource/resource_bundle.h" 12 #include "ui/base/resource/resource_bundle.h"
12 #include "ui/gfx/rect.h" 13 #include "ui/gfx/rect.h"
13 #include "ui/views/border.h" 14 #include "ui/views/border.h"
14 #include "ui/views/context_menu_controller.h" 15 #include "ui/views/context_menu_controller.h"
15 #include "ui/views/controls/button/button.h" 16 #include "ui/views/controls/button/button.h"
16 #include "ui/views/controls/button/checkbox.h" 17 #include "ui/views/controls/button/checkbox.h"
17 #include "ui/views/controls/button/image_button.h" 18 #include "ui/views/controls/button/image_button.h"
18 #include "ui/views/controls/label.h" 19 #include "ui/views/controls/label.h"
19 #include "ui/views/layout/box_layout.h" 20 #include "ui/views/layout/box_layout.h"
20 #include "ui/views/layout/layout_constants.h" 21 #include "ui/views/layout/layout_constants.h"
21 22
22 namespace { 23 namespace {
23 24
24 // Equal to the #9F9F9F color used in spec (note WebUI color is #999). 25 // Equal to the #9F9F9F color used in spec (note WebUI color is #999).
25 const SkColor kDeemphasizedTextColor = SkColorSetRGB(159, 159, 159); 26 const SkColor kDeemphasizedTextColor = SkColorSetRGB(159, 159, 159);
26 27
27 } // namespace 28 } // namespace
28 29
29 MediaGalleryCheckboxView::MediaGalleryCheckboxView( 30 MediaGalleryCheckboxView::MediaGalleryCheckboxView(
30 const base::string16& label, 31 const MediaGalleryPrefInfo& pref_info,
31 const base::string16& tooltip_text,
32 const base::string16& details,
33 bool show_folder_button, 32 bool show_folder_button,
34 int trailing_vertical_space, 33 int trailing_vertical_space,
35 views::ButtonListener* button_listener, 34 views::ButtonListener* button_listener,
36 views::ContextMenuController* menu_controller) { 35 views::ContextMenuController* menu_controller) {
37 DCHECK(button_listener != NULL); 36 DCHECK(button_listener != NULL);
38 SetLayoutManager( 37 SetLayoutManager(
39 new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 0)); 38 new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 0));
40 SetBorder(views::Border::CreateEmptyBorder( 39 SetBorder(views::Border::CreateEmptyBorder(
41 0, views::kPanelHorizMargin, trailing_vertical_space, 40 0, views::kPanelHorizMargin, trailing_vertical_space,
42 views::kPanelHorizMargin)); 41 views::kPanelHorizMargin));
43 if (menu_controller) 42 if (menu_controller)
44 set_context_menu_controller(menu_controller); 43 set_context_menu_controller(menu_controller);
45 44
46 checkbox_ = new views::Checkbox(label); 45 checkbox_ = new views::Checkbox(pref_info.GetGalleryDisplayName());
47 checkbox_->set_listener(button_listener); 46 checkbox_->set_listener(button_listener);
48 if (menu_controller) 47 if (menu_controller)
49 checkbox_->set_context_menu_controller(menu_controller); 48 checkbox_->set_context_menu_controller(menu_controller);
50 checkbox_->SetElideBehavior(gfx::ELIDE_MIDDLE); 49 checkbox_->SetElideBehavior(gfx::ELIDE_MIDDLE);
50 base::string16 tooltip_text = pref_info.GetGalleryTooltip();
51 checkbox_->SetTooltipText(tooltip_text); 51 checkbox_->SetTooltipText(tooltip_text);
52 52
53 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 53 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
54 folder_viewer_button_ = new views::ImageButton(button_listener); 54 folder_viewer_button_ = new views::ImageButton(button_listener);
55 if (menu_controller) 55 if (menu_controller)
56 folder_viewer_button_->set_context_menu_controller(menu_controller); 56 folder_viewer_button_->set_context_menu_controller(menu_controller);
57 folder_viewer_button_->SetImage(views::ImageButton::STATE_NORMAL, 57 folder_viewer_button_->SetImage(views::ImageButton::STATE_NORMAL,
58 rb.GetImageSkiaNamed(IDR_FILE_FOLDER)); 58 rb.GetImageSkiaNamed(IDR_FILE_FOLDER));
59 folder_viewer_button_->SetImageAlignment(views::ImageButton::ALIGN_CENTER, 59 folder_viewer_button_->SetImageAlignment(views::ImageButton::ALIGN_CENTER,
60 views::ImageButton::ALIGN_MIDDLE); 60 views::ImageButton::ALIGN_MIDDLE);
61 folder_viewer_button_->SetAccessibleName(l10n_util::GetStringUTF16( 61 folder_viewer_button_->SetAccessibleName(l10n_util::GetStringUTF16(
62 IDS_MEDIA_GALLERIES_SCAN_RESULT_OPEN_FOLDER_VIEW_ACCESSIBILITY_NAME)); 62 IDS_MEDIA_GALLERIES_SCAN_RESULT_OPEN_FOLDER_VIEW_ACCESSIBILITY_NAME));
63 folder_viewer_button_->SetFocusable(true); 63 folder_viewer_button_->SetFocusable(true);
64 folder_viewer_button_->SetVisible(show_folder_button); 64 folder_viewer_button_->SetVisible(show_folder_button);
65 folder_viewer_button_->SetBorder(views::Border::CreateEmptyBorder( 65 folder_viewer_button_->SetBorder(views::Border::CreateEmptyBorder(
66 0, views::kRelatedControlSmallHorizontalSpacing, 0, 0)); 66 0, views::kRelatedControlSmallHorizontalSpacing, 0, 0));
67 67
68 base::string16 details = pref_info.GetGalleryAdditionalDetails();
68 secondary_text_ = new views::Label(details); 69 secondary_text_ = new views::Label(details);
69 if (menu_controller) 70 if (menu_controller)
70 secondary_text_->set_context_menu_controller(menu_controller); 71 secondary_text_->set_context_menu_controller(menu_controller);
71 secondary_text_->SetVisible(details.length() > 0); 72 secondary_text_->SetVisible(details.length() > 0);
72 secondary_text_->SetEnabledColor(kDeemphasizedTextColor); 73 secondary_text_->SetEnabledColor(kDeemphasizedTextColor);
73 secondary_text_->SetElideBehavior(gfx::ELIDE_HEAD); 74 secondary_text_->SetElideBehavior(gfx::ELIDE_HEAD);
74 secondary_text_->SetTooltipText(tooltip_text); 75 secondary_text_->SetTooltipText(tooltip_text);
75 secondary_text_->SetBorder(views::Border::CreateEmptyBorder( 76 secondary_text_->SetBorder(views::Border::CreateEmptyBorder(
76 0, views::kRelatedControlSmallHorizontalSpacing, 0, 0)); 77 0, views::kRelatedControlSmallHorizontalSpacing, 0, 0));
77 78
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 if (folder_viewer_button_->visible()) { 113 if (folder_viewer_button_->visible()) {
113 folder_viewer_button_->SetBounds(checkbox_->x() + checkbox_width, area.y(), 114 folder_viewer_button_->SetBounds(checkbox_->x() + checkbox_width, area.y(),
114 folder_viewer_width, area.height()); 115 folder_viewer_width, area.height());
115 } 116 }
116 if (secondary_text_->visible()) { 117 if (secondary_text_->visible()) {
117 secondary_text_->SetBounds( 118 secondary_text_->SetBounds(
118 checkbox_->x() + checkbox_width + folder_viewer_width, 119 checkbox_->x() + checkbox_width + folder_viewer_width,
119 area.y(), secondary_text_width, area.height()); 120 area.y(), secondary_text_width, area.height());
120 } 121 }
121 } 122 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698