Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 323013004: Clean up transform methods in GraphicsContext. (Closed)

Created:
6 years, 6 months ago by Stephen Chennney
Modified:
6 years, 6 months ago
CC:
aandrey+blink_chromium.org, abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-rendering, Rik, danakj, dglazkov+blink, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jamesr, jbroman, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr., rwlbuis, rune+blink, Stephen Chennney, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Clean up transform methods in GraphicsContext. GraphicsContext::scale takes a FloatSize, which is not the way most callers wish to invoke it. Here we change it to take x and y scale. GraphicsContext::getCTM is not truly reflective of the tranforms applied to get a pixel on the screen, as it ignores compositor applied transforms. There are numerous locations where the CTM is used to test pixel-level results, such as the width of a line. These tests are not accurate in the presence of high DPI or other zoom factors. Each location gets a FIXME indicating the problem. R=fmalita,esprehn BUG=383070, 382491 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175960

Patch Set 1 #

Patch Set 2 : Fix Mac build #

Patch Set 3 : 2nd Attempt Mac build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -71 lines) Patch
M Source/core/frame/LocalFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/PrintContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/ImageQualityController.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 1 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderWidget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/platform/DragImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/CrossfadeGeneratedImage.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/GradientGeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M Source/platform/graphics/GraphicsContextTest.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FETile.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mac/ThemeMac.mm View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Stephen Chennney
Simple cleanup and placeholder for future fixes. Web code should be rubber stamp.
6 years, 6 months ago (2014-06-10 20:38:11 UTC) #1
esprehn
lgtm
6 years, 6 months ago (2014-06-11 00:08:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/323013004/40001
6 years, 6 months ago (2014-06-11 00:09:01 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-11 01:07:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 01:08:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/22749) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/15998)
6 years, 6 months ago (2014-06-11 01:08:04 UTC) #6
Stephen Chennney
The CQ bit was checked by schenney@chromium.org
6 years, 6 months ago (2014-06-11 15:26:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/323013004/40001
6 years, 6 months ago (2014-06-11 15:27:08 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 15:28:26 UTC) #9
Message was sent while issue was closed.
Change committed as 175960

Powered by Google App Engine
This is Rietveld 408576698