Issue 322973002: Merge 275859 "Add "One Key Theater" DLLs to the browser DLL blac..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322973002: Merge 275859 "Add "One Key Theater" DLLs to the browser DLL blac..." (Closed)

Created:
6 years, 6 months ago by amineer_google

Modified:
6 years, 6 months ago

Reviewers:
Will Harris

CC:
chromium-reviews, caitkp+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/2041/src/

Visibility:
Public.

More Reviews

Description

Merge 275859 "Add "One Key Theater" DLLs to the browser DLL blac..." > Add "One Key Theater" DLLs to the browser DLL blacklist. > > These DLLs were causing major instabilities on Stable Channel. > > BUG=379218 > NOTRY=true > > Review URL: https://codereview.chromium.org/320653003 TBR=wfh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275929

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome_elf/blacklist/blacklist.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Will Harris

On 2014/06/10 03:36:34, amineer wrote: > Committed patchset #1 manually as r275929. LGTM. This missed ...

6 years, 6 months ago (2014-06-10 03:42:52 UTC) #3

chromium-reviews

6 years, 6 months ago (2014-06-10 03:44:23 UTC) #4

Yeah, branch was cut at 275840.

On Mon, Jun 9, 2014 at 8:42 PM, <wfh@chromium.org> wrote:

> On 2014/06/10 03:36:34, amineer wrote:
>
>> Committed patchset #1 manually as r275929.
>>
>
> LGTM. This missed the branch?
>
> https://codereview.chromium.org/322973002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages