Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 320653003: Add "One Key Theater" DLLs to the browser DLL blacklist. (Closed)

Created:
6 years, 6 months ago by Will Harris
Modified:
6 years, 6 months ago
Reviewers:
jschuh, csharp
CC:
chromium-reviews, caitkp+watch_chromium.org
Visibility:
Public.

Description

Add "One Key Theater" DLLs to the browser DLL blacklist. These DLLs were causing major instabilities on Stable Channel. BUG=379218 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome_elf/blacklist/blacklist.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Will Harris
Almost all the crashes were in Browser process, so blacklist in g_troublesome_dlls.
6 years, 6 months ago (2014-06-06 23:32:43 UTC) #1
Will Harris
On 2014/06/06 23:32:43, Will Harris wrote: > Almost all the crashes were in Browser process, ...
6 years, 6 months ago (2014-06-06 23:33:37 UTC) #2
jschuh
On 2014/06/06 23:33:37, Will Harris wrote: > On 2014/06/06 23:32:43, Will Harris wrote: > > ...
6 years, 6 months ago (2014-06-06 23:42:36 UTC) #3
Will Harris
The CQ bit was checked by wfh@chromium.org
6 years, 6 months ago (2014-06-07 00:37:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/320653003/1
6 years, 6 months ago (2014-06-07 00:39:40 UTC) #5
Will Harris
On 2014/06/07 00:39:40, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-07 01:15:53 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 05:30:23 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-07 05:33:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/72357)
6 years, 6 months ago (2014-06-07 05:33:23 UTC) #9
csharp
lgtm
6 years, 6 months ago (2014-06-09 16:40:09 UTC) #10
Will Harris
The CQ bit was unchecked by wfh@chromium.org
6 years, 6 months ago (2014-06-09 16:50:33 UTC) #11
Will Harris
The CQ bit was checked by wfh@chromium.org
6 years, 6 months ago (2014-06-09 16:50:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/320653003/1
6 years, 6 months ago (2014-06-09 16:51:17 UTC) #13
Will Harris
The CQ bit was unchecked by wfh@chromium.org
6 years, 6 months ago (2014-06-09 21:27:07 UTC) #14
Will Harris
The CQ bit was checked by wfh@chromium.org
6 years, 6 months ago (2014-06-09 21:27:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/320653003/1
6 years, 6 months ago (2014-06-09 21:29:27 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 21:32:20 UTC) #17
Message was sent while issue was closed.
Change committed as 275859

Powered by Google App Engine
This is Rietveld 408576698