| 
 | 
 | 
 Chromium Code Reviews
 Chromium Code Reviews Issue 
            320653003:
    Add "One Key Theater" DLLs to the browser DLL blacklist.  (Closed)
    
  
    Issue 
            320653003:
    Add "One Key Theater" DLLs to the browser DLL blacklist.  (Closed) 
  | Created: 6 years, 6 months ago by Will Harris Modified: 6 years, 6 months ago CC: chromium-reviews, caitkp+watch_chromium.org Base URL: svn://svn.chromium.org/chrome/trunk/src Visibility: Public. | DescriptionAdd "One Key Theater" DLLs to the browser DLL blacklist.
These DLLs were causing major instabilities on Stable Channel.
BUG=379218
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275859
   Patch Set 1 #
 Messages
    Total messages: 17 (0 generated)
     
 Almost all the crashes were in Browser process, so blacklist in g_troublesome_dlls. 
 On 2014/06/06 23:32:43, Will Harris wrote: > Almost all the crashes were in Browser process, so blacklist in > g_troublesome_dlls. I did consider #if defined(_WIN64) around the 64-bit ones, but I don't think there is any issue with blacklisting both 32-bit and 64-bit DLLs in both processes. 
 On 2014/06/06 23:33:37, Will Harris wrote: > On 2014/06/06 23:32:43, Will Harris wrote: > > Almost all the crashes were in Browser process, so blacklist in > > g_troublesome_dlls. > > I did consider #if defined(_WIN64) around the 64-bit ones, but I don't think > there is any issue with blacklisting both 32-bit and 64-bit DLLs in both > processes. Yeah, I wouldn't bother scoping it to win64 unless we see issues. So, lgtm. 
 The CQ bit was checked by wfh@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/320653003/1 
 On 2014/06/07 00:39:40, I haz the power (commit-bot) wrote: > CQ is trying da patch. Follow status at > https://chromium-status.appspot.com/cq/wfh@chromium.org/320653003/1 +csharp for OWNER. 
 FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) 
 lgtm 
 The CQ bit was unchecked by wfh@chromium.org 
 The CQ bit was checked by wfh@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/320653003/1 
 The CQ bit was unchecked by wfh@chromium.org 
 The CQ bit was checked by wfh@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/320653003/1 
 
            
              
                Message was sent while issue was closed.
              
            
             Change committed as 275859 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
