chrome/browser/extensions/shared_module_service_unittest.cc - Issue 322893002: Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/shared_module_service_unittest.cc

Issue 322893002: Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/test_extension_prefs.cc » ('j') | extensions/browser/extension_prefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/shared_module_service_unittest.cc

diff --git a/chrome/browser/extensions/shared_module_service_unittest.cc b/chrome/browser/extensions/shared_module_service_unittest.cc

index 388453ee53309bf20c1bc0aee3ef26359a9c23c1..b60aec6f6f877f2155f978d95006e0668c08e616 100644

--- a/chrome/browser/extensions/shared_module_service_unittest.cc

+++ b/chrome/browser/extensions/shared_module_service_unittest.cc

@@ -12,6 +12,7 @@

#include "chrome/browser/extensions/shared_module_service.h"

#include "chrome/common/extensions/features/feature_channel.h"

#include "extensions/browser/extension_registry.h"

+#include "extensions/browser/install_flag.h"

#include "extensions/common/extension_builder.h"

#include "extensions/common/id_util.h"

#include "extensions/common/value_builder.h"

@@ -72,12 +73,8 @@ testing::AssertionResult SharedModuleServiceUnitTest::InstallExtension(

// Notify the service that the extension is installed. This adds it to the

// registry, notifies interested parties, etc.

- service_->OnExtensionInstalled(extension,

- syncer::StringOrdinal(),

- false, // No requirement errors.

- NOT_BLACKLISTED,

- false, // Not ephemeral.

- false); // Don't wait for idle.

+ service_->OnExtensionInstalled(

+ extension, syncer::StringOrdinal(), kInstallFlagInstallImmediately);

// Verify that the extension is now installed.

if (!registry_->GetExtensionById(extension->id(),