chrome/browser/extensions/extension_service_unittest.cc - Issue 322893002: Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 322893002: Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/shared_module_service_unittest.cc » ('j') | extensions/browser/extension_prefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc

index a0d61e57f955a75a75c1035022661be76e2ae0ba..35546c974adf81928ccdbf22616e10a7320164b3 100644

--- a/chrome/browser/extensions/extension_service_unittest.cc

+++ b/chrome/browser/extensions/extension_service_unittest.cc

@@ -93,6 +93,7 @@

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/external_provider_interface.h"

+#include "extensions/browser/install_flag.h"

#include "extensions/browser/management_policy.h"

#include "extensions/browser/pref_names.h"

#include "extensions/browser/test_management_policy.h"

@@ -6940,10 +6941,8 @@ TEST_F(ExtensionServiceTest, InstallBlacklistedExtension) {

service_->OnExtensionInstalled(

extension.get(),

syncer::StringOrdinal(),

- false /* has requirement errors */,

- extensions::BLACKLISTED_MALWARE,

- false /* is ephemeral */,

- false /* wait for idle */);

+ (extensions::kInstallFlagIsBlacklistedForMalware |

+ extensions::kInstallFlagInstallImmediately));

base::RunLoop().RunUntilIdle();

// Extension was installed but not loaded.