chrome/common/extensions/api/browser_action.json - Issue 32283005: Mark window parameter for chrome.browserAction.openPopup as optional since it is not provided when …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/browser_action.json

Issue 32283005: Mark window parameter for chrome.browserAction.openPopup as optional since it is not provided when … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: lasterror Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/api/browser_action.json

diff --git a/chrome/common/extensions/api/browser_action.json b/chrome/common/extensions/api/browser_action.json

index 698cf178fe1e63b7e4590a6109d7db6af0272bfa..e6f5d15dc3cf027c13adffb8f422a492ad4b985c 100644

--- a/chrome/common/extensions/api/browser_action.json

+++ b/chrome/common/extensions/api/browser_action.json

@@ -324,6 +324,7 @@

{

"name": "popupView",

"type": "object",

+ "optional": true,

not at google - send to devlin 2013/10/24 00:16:26 add description to this?

justinlin 2013/10/24 00:26:56 Done.

"additionalProperties": { "type": "any" }

}

]

« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('j') | no next file with comments »