Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: chrome/common/extensions/api/browser_action.json

Issue 32283005: Mark window parameter for chrome.browserAction.openPopup as optional since it is not provided when … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: lasterror Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 [ 5 [
6 { 6 {
7 "namespace": "browserAction", 7 "namespace": "browserAction",
8 "description": "Use browser actions to put icons in the main Google Chrome t oolbar, to the right of the address bar. In addition to its <a href='#icon'>icon </a>, a browser action can also have a <a href='#tooltip'>tooltip</a>, a <a href ='#badge'>badge</a>, and a <a href = '#popups'>popup</a>.", 8 "description": "Use browser actions to put icons in the main Google Chrome t oolbar, to the right of the address bar. In addition to its <a href='#icon'>icon </a>, a browser action can also have a <a href='#tooltip'>tooltip</a>, a <a href ='#badge'>badge</a>, and a <a href = '#popups'>popup</a>.",
9 "types": [ 9 "types": [
10 { 10 {
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 "description": "Opens the extension popup window in the active window bu t does not grant tab permissions.", 317 "description": "Opens the extension popup window in the active window bu t does not grant tab permissions.",
318 "nodoc": true, 318 "nodoc": true,
319 "parameters": [ 319 "parameters": [
320 { 320 {
321 "type": "function", 321 "type": "function",
322 "name": "callback", 322 "name": "callback",
323 "parameters": [ 323 "parameters": [
324 { 324 {
325 "name": "popupView", 325 "name": "popupView",
326 "type": "object", 326 "type": "object",
327 "optional": true,
not at google - send to devlin 2013/10/24 00:16:26 add description to this?
justinlin 2013/10/24 00:26:56 Done.
327 "additionalProperties": { "type": "any" } 328 "additionalProperties": { "type": "any" }
328 } 329 }
329 ] 330 ]
330 } 331 }
331 ] 332 ]
332 } 333 }
333 ], 334 ],
334 "events": [ 335 "events": [
335 { 336 {
336 "name": "onClicked", 337 "name": "onClicked",
337 "type": "function", 338 "type": "function",
338 "description": "Fired when a browser action icon is clicked. This event will not fire if the browser action has a popup.", 339 "description": "Fired when a browser action icon is clicked. This event will not fire if the browser action has a popup.",
339 "parameters": [ 340 "parameters": [
340 { 341 {
341 "name": "tab", 342 "name": "tab",
342 "$ref": "tabs.Tab" 343 "$ref": "tabs.Tab"
343 } 344 }
344 ] 345 ]
345 } 346 }
346 ] 347 ]
347 } 348 }
348 ] 349 ]
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698