Issue 32283005: Mark window parameter for chrome.browserAction.openPopup as optional since it is not provided when …

Issue 32283005: Mark window parameter for chrome.browserAction.openPopup as optional since it is not provided when … (Closed)

Created:
7 years, 2 months ago by justinlin

Modified:
7 years, 2 months ago

Reviewers:
Matt Perry, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mark window parameter for chrome.browserAction.openPopup as optional since it is not provided when opening a popup fails. Don't throw exception when openPopup fails to get the popup window. BUG=305737 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230617

Patch Set 1 : #

Patch Set 2 : lasterror #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	chrome/common/extensions/api/browser_action.json	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/renderer/resources/extensions/browser_action_custom_bindings.js	View	1	1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm https://codereview.chromium.org/32283005/diff/40001/chrome/common/extensions/api/browser_action.json File chrome/common/extensions/api/browser_action.json (right): https://codereview.chromium.org/32283005/diff/40001/chrome/common/extensions/api/browser_action.json#newcode327 chrome/common/extensions/api/browser_action.json:327: "optional": true, add description to this?

7 years, 2 months ago (2013-10-24 00:16:26 UTC) #3

justinlin

thanks https://codereview.chromium.org/32283005/diff/40001/chrome/common/extensions/api/browser_action.json File chrome/common/extensions/api/browser_action.json (right): https://codereview.chromium.org/32283005/diff/40001/chrome/common/extensions/api/browser_action.json#newcode327 chrome/common/extensions/api/browser_action.json:327: "optional": true, On 2013/10/24 00:16:26, kalman wrote: > ...

7 years, 2 months ago (2013-10-24 00:26:56 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/32283005/60001

7 years, 2 months ago (2013-10-24 00:30:53 UTC) #5

Message was sent while issue was closed.

Change committed as 230617

Expand Messages | Collapse Messages