Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 322813002: [SyncFS] Drop test only un-thread-safe getters from SyncEngine (4) (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Drop test only un-thread-safe getters from SyncEngine BUG=347425, 380615 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275971

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : buildfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tzik
PTL
6 years, 6 months ago (2014-06-09 13:25:15 UTC) #1
peria
https://codereview.chromium.org/322813002/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc File chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc (right): https://codereview.chromium.org/322813002/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc#newcode574 chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:574: SyncEngineContext* context() { This method is used only in ...
6 years, 6 months ago (2014-06-10 03:18:15 UTC) #2
tzik
https://codereview.chromium.org/322813002/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc File chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc (right): https://codereview.chromium.org/322813002/diff/1/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc#newcode574 chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:574: SyncEngineContext* context() { On 2014/06/10 03:18:15, peria wrote: > ...
6 years, 6 months ago (2014-06-10 03:53:23 UTC) #3
peria
lgtm
6 years, 6 months ago (2014-06-10 03:56:02 UTC) #4
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-10 06:11:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/322813002/60001
6 years, 6 months ago (2014-06-10 06:16:00 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 06:19:34 UTC) #7
Message was sent while issue was closed.
Change committed as 275971

Powered by Google App Engine
This is Rietveld 408576698