Initialize min/max record time to 0 instead of -1 or null

Initialize min/max record time to 0 instead of -1 or null

This simplifies many boundary time computations all around the code.

BUG=361045
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175801

[alph, 2014-06-09 09:31:14]

lgtm

https://codereview.chromium.org/322783002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TimelineModel.js (right):

https://codereview.chromium.org/322783002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TimelineModel.js:291: if
((!this._maximumRecordTime && endTime) || endTime > this._maximumRecordTime)
Looks like you can drop the part before ||

[yurys, 2014-06-09 09:46:08]

https://codereview.chromium.org/322783002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TimelineModel.js (right):

https://codereview.chromium.org/322783002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TimelineModel.js:291: if
((!this._maximumRecordTime && endTime) || endTime > this._maximumRecordTime)
On 2014/06/09 09:31:14, alph wrote:
> Looks like you can drop the part before ||

endTime may be undefined and we may end up comparing undefined with something
(which is allowed but not that obvious).

[alph, 2014-06-09 10:09:19]

https://codereview.chromium.org/322783002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TimelineModel.js (right):

https://codereview.chromium.org/322783002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TimelineModel.js:291: if
((!this._maximumRecordTime && endTime) || endTime > this._maximumRecordTime)
On 2014/06/09 09:46:08, yurys wrote:
> On 2014/06/09 09:31:14, alph wrote:
> > Looks like you can drop the part before ||
> 
> endTime may be undefined and we may end up comparing undefined with something
> (which is allowed but not that obvious).

According to
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
it shouldn't be undefined.

[yurys, 2014-06-09 11:16:37]

https://codereview.chromium.org/322783002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TimelineModel.js (right):

https://codereview.chromium.org/322783002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TimelineModel.js:291: if
((!this._maximumRecordTime && endTime) || endTime > this._maximumRecordTime)
On 2014/06/09 10:09:19, alph wrote:
> According to
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> it shouldn't be undefined.
You're right. I confused that with TracingModel.Event.endTime, will update this
change.

[loislo, 2014-06-09 11:49:42]

On 2014/06/09 11:16:37, yurys wrote:
>
https://codereview.chromium.org/322783002/diff/1/Source/devtools/front_end/ti...
> File Source/devtools/front_end/timeline/TimelineModel.js (right):
> 
>
https://codereview.chromium.org/322783002/diff/1/Source/devtools/front_end/ti...
> Source/devtools/front_end/timeline/TimelineModel.js:291: if
> ((!this._maximumRecordTime && endTime) || endTime > this._maximumRecordTime)
> On 2014/06/09 10:09:19, alph wrote:
> > According to
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> > it shouldn't be undefined.
> You're right. I confused that with TracingModel.Event.endTime, will update
this
> change.

lgtm

[yurys, 2014-06-09 13:07:18]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-06-09 13:08:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yurys@chromium.org/322783002/20001

[commit-bot: I haz the power, 2014-06-09 14:12:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-09 14:12:41]

Failed to apply patch for Source/devtools/front_end/timeline/TimelinePanel.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/timeline/TimelinePanel.js
  Hunk #1 FAILED at 204.
  Hunk #2 FAILED at 217.
  2 out of 2 hunks FAILED -- saving rejects to file
Source/devtools/front_end/timeline/TimelinePanel.js.rej

Patch:       Source/devtools/front_end/timeline/TimelinePanel.js
Index: Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js
b/Source/devtools/front_end/timeline/TimelinePanel.js
index
228aa09f83155ce4a70ac0aafbcb4c92d23d829f..ca8beecc879b1c5ec2490bd79f49ace8c063f0e6
100644
--- a/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -204,10 +204,7 @@ WebInspector.TimelinePanel.prototype = {
     {
         if (this._windowStartTime)
             return this._windowStartTime;
-        var minimumRecordTime = this._model.minimumRecordTime();
-        if (minimumRecordTime && minimumRecordTime != -1)
-            return minimumRecordTime;
-        return 0;
+        return this._model.minimumRecordTime();
     },
 
     /**
@@ -217,10 +214,7 @@ WebInspector.TimelinePanel.prototype = {
     {
         if (this._windowEndTime < Infinity)
             return this._windowEndTime;
-        var maximumRecordTime = this._model.maximumRecordTime();
-        if (maximumRecordTime && maximumRecordTime != -1)
-            return maximumRecordTime;
-        return Infinity;
+        return this._model.maximumRecordTime() || Infinity;
     },
 
     /**

[yurys, 2014-06-09 14:22:22]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-06-09 14:23:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yurys@chromium.org/322783002/40001

[commit-bot: I haz the power, 2014-06-09 15:24:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11280)

[commit-bot: I haz the power, 2014-06-09 16:00:19]

Change committed as 175801