Source/devtools/front_end/timeline/TimelineModel.js - Issue 322783002: Initialize min/max record time to 0 instead of -1 or null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 322783002: Initialize min/max record time to 0 instead of -1 or null (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/timeline/TimelineModel.js

diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js

index 35ebfb508f4abf7979b4da5c3ed17af72e566416..2c310fcf07bc511c654cffc5caeec2c86ad28c80 100644

--- a/Source/devtools/front_end/timeline/TimelineModel.js

+++ b/Source/devtools/front_end/timeline/TimelineModel.js

@@ -251,8 +251,8 @@ WebInspector.TimelineModel.prototype = {

{

this._loadedFromFile = false;

this._records = [];

- this._minimumRecordTime = -1;

- this._maximumRecordTime = -1;

+ this._minimumRecordTime = 0;

+ this._maximumRecordTime = 0;

/** @type {!Array.<!WebInspector.TimelineModel.Record>} */

this._mainThreadTasks = [];

/** @type {!Array.<!WebInspector.TimelineModel.Record>} */

@@ -286,9 +286,9 @@ WebInspector.TimelineModel.prototype = {

var startTime = record.startTime();

var endTime = record.endTime();

- if (this._minimumRecordTime === -1 || startTime < this._minimumRecordTime)

+ if (!this._minimumRecordTime || startTime < this._minimumRecordTime)

this._minimumRecordTime = startTime;

- if ((this._maximumRecordTime === -1 && endTime) || endTime > this._maximumRecordTime)

+ if (endTime > this._maximumRecordTime)

this._maximumRecordTime = endTime;