Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 322733002: Translate: Bug fix: need to normalize the language code for Translate UI (Closed)

Created:
6 years, 6 months ago by Takashi Toyoshima
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Translate: Bug fix: need to normalize the language code for Translate UI Take over this CL from hajimehoshi@chromium.org, and just rebase the CL to trunk. Original description by hajimehoshi@ follows; Before passing the language code to Translate UI, this must be normalized (like 'hi-IN' -> 'hi'). I mistakenly droped this process when moving GetTranslateLanguages from translate_bubble_view.cc to translate_tab_helper.cc (https://codereview.chromium.org/203223002) :-( BUG=380137 R=toyoshim@chromium.org TBR=hajimehoshi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275786

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/translate/chrome_translate_client.cc View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
Takashi Toyoshima
https://codereview.chromium.org/322733002/diff/1/chrome/browser/translate/chrome_translate_client.cc File chrome/browser/translate/chrome_translate_client.cc (right): https://codereview.chromium.org/322733002/diff/1/chrome/browser/translate/chrome_translate_client.cc#newcode129 chrome/browser/translate/chrome_translate_client.cc:129: *source = TranslateDownloadManager::GetLanguageCode( take over from https://codereview.chromium.org/317623003
6 years, 6 months ago (2014-06-09 05:23:18 UTC) #1
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 6 months ago (2014-06-09 05:23:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/322733002/1
6 years, 6 months ago (2014-06-09 05:24:14 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 05:24:15 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-09 05:24:15 UTC) #5
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 6 months ago (2014-06-09 05:24:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/322733002/1
6 years, 6 months ago (2014-06-09 05:24:43 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-09 07:56:43 UTC) #8
commit-bot: I haz the power
Change committed as 275786
6 years, 6 months ago (2014-06-09 11:11:57 UTC) #9
hajimehoshi
6 years, 6 months ago (2014-06-10 22:35:57 UTC) #10
Message was sent while issue was closed.
Thank you, but is this meagiable to M36?

Powered by Google App Engine
This is Rietveld 408576698