Translate: Bug fix: need to normalize the language code for Translate UI

Translate: Bug fix: need to normalize the language code for Translate UI

Before passing the language code to Translate UI, this must be
normalized (like 'hi-IN' -> 'hi').

I mistakenly droped this process when moving GetTranslateLanguages from
translate_bubble_view.cc to translate_tab_helper.cc
(https://codereview.chromium.org/203223002) :-(

BUG=380137
R=toyoshim@chromium.org

[hajimehoshi, 2014-06-04 08:01:17]

PTAL

[hajimehoshi, 2014-06-04 08:01:17]

PTAL

[Takashi Toyoshima, 2014-06-04 20:39:33]

lgtm

https://codereview.chromium.org/317623003/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_tab_helper.cc (right):

https://codereview.chromium.org/317623003/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_tab_helper.cc:126: *source =
TranslateDownloadManager::GetLanguageCode(*source);
Optional suggestion.

If you want to store the temporary result of
GetLanguageState().original_language(), it might be better to use another
variable with a meaningful name.
Or, just like
*source = TranslateDownloadManager::GetLanguageCode(
    translate_tab_helper->GetLanguageState().original_language());

But, it may be just my preference. So it's up to you.

[hajimehoshi, 2014-06-05 08:42:53]

Thanks!

https://codereview.chromium.org/317623003/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_tab_helper.cc (right):

https://codereview.chromium.org/317623003/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_tab_helper.cc:126: *source =
TranslateDownloadManager::GetLanguageCode(*source);
On 2014/06/04 20:39:33, Takashi Toyoshima (chromium) wrote:
> Optional suggestion.
> 
> If you want to store the temporary result of
> GetLanguageState().original_language(), it might be better to use another
> variable with a meaningful name.
> Or, just like
> *source = TranslateDownloadManager::GetLanguageCode(
>     translate_tab_helper->GetLanguageState().original_language());
> 
> But, it may be just my preference. So it's up to you.

Done.

[hajimehoshi, 2014-06-05 08:42:57]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2014-06-05 08:44:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/317623003/20001

[commit-bot: I haz the power, 2014-06-05 09:16:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/13280)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/16366)

[commit-bot: I haz the power, 2014-06-05 09:19:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 09:19:46]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[hajimehoshi, 2014-06-05 11:03:44]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2014-06-05 11:05:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/317623003/20001

[commit-bot: I haz the power, 2014-06-05 11:30:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/13330)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/16417)

[commit-bot: I haz the power, 2014-06-05 11:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 11:32:55]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[hajimehoshi, 2014-06-06 22:23:30]

toyoshim: I'm ooo until the end of the next week, so I can't treat this CL. Can
you take over this CL and crbug/380137?

[Takashi Toyoshima, 2014-06-09 05:21:41]

OK.
I take over this CL and land it as https://codereview.chromium.org/322733002/.
translate_tab_helper.cc was renamed to chrome_translate_client.cc in trunk.

[hajimehoshi, 2014-06-10 22:32:47]

Thank you!


On Mon, Jun 9, 2014 at 7:21 AM, <toyoshim@chromium.org> wrote:

> OK.
> I take over this CL and land it as https://codereview.chromium.
> org/322733002/.
> translate_tab_helper.cc was renamed to chrome_translate_client.cc in trunk.
>
> https://codereview.chromium.org/317623003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.