Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/media/webrtc_rtp_dump_writer.cc

Issue 322603003: Fix a crash in WebRtcRtpDumpHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_rtp_dump_writer.cc
diff --git a/chrome/browser/media/webrtc_rtp_dump_writer.cc b/chrome/browser/media/webrtc_rtp_dump_writer.cc
index aa9434e6280545cc494b8764e0922b622f4b172d..e9a360455922967287f8034b4ccc45ed67c0fa48 100644
--- a/chrome/browser/media/webrtc_rtp_dump_writer.cc
+++ b/chrome/browser/media/webrtc_rtp_dump_writer.cc
@@ -447,5 +447,6 @@ void WebRtcRtpDumpWriter::OnDumpEnded(EndDumpContext context,
return;
}
+ // This object might be deleted after running the callback.
context.callback.Run(context.incoming_succeeded, context.outgoing_succeeded);
}
« no previous file with comments | « chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698