Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1693)

Unified Diff: chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc

Issue 322603003: Fix a crash in WebRtcRtpDumpHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/webrtc_rtp_dump_handler.cc ('k') | chrome/browser/media/webrtc_rtp_dump_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc
diff --git a/chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc b/chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc
index 89965b599c0f54e59023e49b5147378409b97559..96e74365eb85b4e726d438e6e6080e808654134b 100644
--- a/chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc
+++ b/chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc
@@ -79,6 +79,8 @@ class WebRtcRtpDumpHandlerTest : public testing::Test {
handler_->SetDumpWriterForTesting(writer.Pass());
}
+ void DeleteDumpHandler() { handler_.reset(); }
+
void WriteFakeDumpFiles(const base::FilePath& dir,
base::FilePath* incoming_dump,
base::FilePath* outgoing_dump) {
@@ -391,3 +393,19 @@ TEST_F(WebRtcRtpDumpHandlerTest, StopOngoingDumpsWhileStoppingOneDump) {
EXPECT_FALSE(dumps.incoming_dump_path.empty());
EXPECT_FALSE(dumps.outgoing_dump_path.empty());
}
+
+TEST_F(WebRtcRtpDumpHandlerTest, DeleteHandlerBeforeStopCallback) {
+ std::string error;
+
+ EXPECT_CALL(*this, OnStopOngoingDumpsFinished())
+ .WillOnce(testing::InvokeWithoutArgs(
+ this, &WebRtcRtpDumpHandlerTest::DeleteDumpHandler));
+
+ EXPECT_TRUE(handler_->StartDump(RTP_DUMP_BOTH, &error));
+
+ handler_->StopOngoingDumps(
+ base::Bind(&WebRtcRtpDumpHandlerTest::OnStopOngoingDumpsFinished,
+ base::Unretained(this)));
+
+ base::RunLoop().RunUntilIdle();
+}
« no previous file with comments | « chrome/browser/media/webrtc_rtp_dump_handler.cc ('k') | chrome/browser/media/webrtc_rtp_dump_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698