Issue 322593004: [Telemetry] Disable DCHECK crashes in release builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322593004: [Telemetry] Disable DCHECK crashes in release builds. (Closed)

Created:
6 years, 6 months ago by tonyg

Modified:
6 years, 6 months ago

Reviewers:
dtu

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Disable DCHECK crashes in release builds. Telemetry is designed for performance, not functional testing and it is currently bearing more of the weight of these failures than the infra can handle. NOTRY=True BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275580

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

achuithb

On 2014/06/07 01:13:20, tonyg wrote: And they're talking about enabling DCHECKs in canary: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/c2X0D1Z6X2o

6 years, 6 months ago (2014-06-07 01:16:28 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/322593004/1

6 years, 6 months ago (2014-06-07 01:18:02 UTC) #5

tonyg

6 years, 6 months ago (2014-06-07 02:01:45 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/323643003/ by tonyg@chromium.org.

The reason for reverting is: Did not have the desired effect..

Expand Messages | Collapse Messages