Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 322593004: [Telemetry] Disable DCHECK crashes in release builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
index 497ac73bcfdaf4e8ce4251237a9e45032255db75..cc9d4378064bcb62097d4d6df5b49aca4d38c94f 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
@@ -89,6 +89,15 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):
args.append('--no-default-browser-check')
args.append('--no-first-run')
+ # TODO(tonyg): Telemetry runs on release build bots which enable DCHECKs.
+ # While, we'd really like for Chrome to be DCHECK clean, pragmatically, it
+ # is far from it and the Telemetry unittests are hitting DCHECKS so often
+ # that the flakiness is becoming untenable.
+ #
+ # We should remove this as soon as we're ready to get serious about the
+ # DCHECK problem and keep Chrome clean.
+ args.append('--silent-dump-on-dcheck')
+
# Turn on GPU benchmarking extension for all runs. The only side effect of
# the extension being on is that render stats are tracked. This is believed
# to be effectively free. And, by doing so here, it avoids us having to
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698