Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3082)

Unified Diff: base/test/launcher/test_launcher.cc

Issue 322573003: Do not flag unknown tests results as unreliable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/launcher/test_launcher.cc
diff --git a/base/test/launcher/test_launcher.cc b/base/test/launcher/test_launcher.cc
index dca272037cc86c3be3a5863e25a0fe026718f2eb..42b03e5310c5a688eccfa9d0522b2f09105da927 100644
--- a/base/test/launcher/test_launcher.cc
+++ b/base/test/launcher/test_launcher.cc
@@ -449,8 +449,8 @@ void TestLauncher::OnTestFinished(const TestResult& result) {
tests_to_retry_.insert(result.full_name);
}
- if (result.status == TestResult::TEST_UNKNOWN)
- results_tracker_.AddGlobalTag(kUnreliableResultsTag);
+ // TODO(phajdan.jr): Flag unreliable unknown results, unless passed on retry.
+ // See http://crbug.com/381733 .
results_tracker_.AddTestResult(result);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698