Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: base/test/launcher/test_launcher.cc

Issue 322573003: Do not flag unknown tests results as unreliable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/launcher/test_launcher.h" 5 #include "base/test/launcher/test_launcher.h"
6 6
7 #if defined(OS_POSIX) 7 #if defined(OS_POSIX)
8 #include <fcntl.h> 8 #include <fcntl.h>
9 #endif 9 #endif
10 10
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 fprintf(stdout, "%s", result.output_snippet.c_str()); 442 fprintf(stdout, "%s", result.output_snippet.c_str());
443 fflush(stdout); 443 fflush(stdout);
444 } 444 }
445 445
446 if (result.status == TestResult::TEST_SUCCESS) { 446 if (result.status == TestResult::TEST_SUCCESS) {
447 ++test_success_count_; 447 ++test_success_count_;
448 } else { 448 } else {
449 tests_to_retry_.insert(result.full_name); 449 tests_to_retry_.insert(result.full_name);
450 } 450 }
451 451
452 if (result.status == TestResult::TEST_UNKNOWN) 452 // TODO(phajdan.jr): Flag unreliable unknown results, unless passed on retry.
453 results_tracker_.AddGlobalTag(kUnreliableResultsTag); 453 // See http://crbug.com/381733 .
454 454
455 results_tracker_.AddTestResult(result); 455 results_tracker_.AddTestResult(result);
456 456
457 // TODO(phajdan.jr): Align counter (padding). 457 // TODO(phajdan.jr): Align counter (padding).
458 std::string status_line( 458 std::string status_line(
459 StringPrintf("[%" PRIuS "/%" PRIuS "] %s ", 459 StringPrintf("[%" PRIuS "/%" PRIuS "] %s ",
460 test_finished_count_, 460 test_finished_count_,
461 test_started_count_, 461 test_started_count_,
462 result.full_name.c_str())); 462 result.full_name.c_str()));
463 if (result.completed()) { 463 if (result.completed()) {
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
1077 1077
1078 g_live_processes.Get().erase(process_handle); 1078 g_live_processes.Get().erase(process_handle);
1079 } 1079 }
1080 1080
1081 base::CloseProcessHandle(process_handle); 1081 base::CloseProcessHandle(process_handle);
1082 1082
1083 return exit_code; 1083 return exit_code;
1084 } 1084 }
1085 1085
1086 } // namespace base 1086 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698