Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 322553004: Uses string16 for ActivityViewModel::GetTitle() (Closed)

Created:
6 years, 6 months ago by Jun Mukai
Modified:
6 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul
Visibility:
Public.

Description

Uses string16 for ActivityViewModel::GetTitle() BUG=381858 R=oshima@chromium.org TEST=compile succeeds Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275708

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix typo of rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M athena/activity/activity_view_manager_impl.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M athena/activity/public/activity_view_model.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M athena/content/web_activity.h View 1 1 chunk +1 line, -1 line 0 comments Download
M athena/content/web_activity.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M athena/test/sample_activity.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M athena/test/sample_activity.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M athena/test/sample_activity_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Jun Mukai
6 years, 6 months ago (2014-06-06 21:02:52 UTC) #1
oshima
lgtm
6 years, 6 months ago (2014-06-06 21:11:32 UTC) #2
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-07 00:13:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/322553004/20001
6 years, 6 months ago (2014-06-07 00:16:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 05:43:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-07 06:13:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/35482)
6 years, 6 months ago (2014-06-07 06:13:59 UTC) #7
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-07 18:47:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/322553004/40001
6 years, 6 months ago (2014-06-07 18:48:07 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 23:33:54 UTC) #10
Message was sent while issue was closed.
Change committed as 275708

Powered by Google App Engine
This is Rietveld 408576698