Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: athena/content/web_activity.h

Issue 322553004: Uses string16 for ActivityViewModel::GetTitle() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo of rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « athena/activity/public/activity_view_model.h ('k') | athena/content/web_activity.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ATHENA_CONTENT_PUBLIC_WEB_ACTIVITY_H_ 5 #ifndef ATHENA_CONTENT_PUBLIC_WEB_ACTIVITY_H_
6 #define ATHENA_CONTENT_PUBLIC_WEB_ACTIVITY_H_ 6 #define ATHENA_CONTENT_PUBLIC_WEB_ACTIVITY_H_
7 7
8 #include "athena/activity/public/activity.h" 8 #include "athena/activity/public/activity.h"
9 #include "athena/activity/public/activity_view_model.h" 9 #include "athena/activity/public/activity_view_model.h"
10 #include "content/public/browser/web_contents_observer.h" 10 #include "content/public/browser/web_contents_observer.h"
(...skipping 14 matching lines...) Expand all
25 public: 25 public:
26 WebActivity(content::BrowserContext* context, const GURL& gurl); 26 WebActivity(content::BrowserContext* context, const GURL& gurl);
27 virtual ~WebActivity(); 27 virtual ~WebActivity();
28 28
29 protected: 29 protected:
30 // Activity: 30 // Activity:
31 virtual athena::ActivityViewModel* GetActivityViewModel() OVERRIDE; 31 virtual athena::ActivityViewModel* GetActivityViewModel() OVERRIDE;
32 32
33 // ActivityViewModel: 33 // ActivityViewModel:
34 virtual SkColor GetRepresentativeColor() OVERRIDE; 34 virtual SkColor GetRepresentativeColor() OVERRIDE;
35 virtual std::string GetTitle() OVERRIDE; 35 virtual base::string16 GetTitle() OVERRIDE;
36 virtual views::View* GetContentsView() OVERRIDE; 36 virtual views::View* GetContentsView() OVERRIDE;
37 37
38 // content::WebContentsObserver: 38 // content::WebContentsObserver:
39 virtual void TitleWasSet(content::NavigationEntry* entry, 39 virtual void TitleWasSet(content::NavigationEntry* entry,
40 bool explicit_set) OVERRIDE; 40 bool explicit_set) OVERRIDE;
41 virtual void DidUpdateFaviconURL( 41 virtual void DidUpdateFaviconURL(
42 const std::vector<content::FaviconURL>& candidates) OVERRIDE; 42 const std::vector<content::FaviconURL>& candidates) OVERRIDE;
43 43
44 private: 44 private:
45 content::BrowserContext* browser_context_; 45 content::BrowserContext* browser_context_;
46 const GURL url_; 46 const GURL url_;
47 views::WebView* web_view_; 47 views::WebView* web_view_;
48 48
49 DISALLOW_COPY_AND_ASSIGN(WebActivity); 49 DISALLOW_COPY_AND_ASSIGN(WebActivity);
50 }; 50 };
51 51
52 } // namespace athena 52 } // namespace athena
53 53
54 #endif // ATHENA_CONTENT_WEB_ACTIVITY_H_ 54 #endif // ATHENA_CONTENT_WEB_ACTIVITY_H_
OLDNEW
« no previous file with comments | « athena/activity/public/activity_view_model.h ('k') | athena/content/web_activity.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698