autocomplete: support address-line3, address-level{1,2,3}

components/autofill/core/browser/autofill_metrics.cc

Index: components/autofill/core/browser/autofill_metrics.cc
diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc
index d1f8e1ed56dc188034214cd1409e2d68af9259d7..f3e471b77f906f7c85db805b4adad2dcb905911f 100644
--- a/components/autofill/core/browser/autofill_metrics.cc
+++ b/components/autofill/core/browser/autofill_metrics.cc
@@ -34,6 +34,7 @@ enum FieldTypeGroupForMetrics {
   CREDIT_CARD_DATE,
   CREDIT_CARD_TYPE,
   PASSWORD,
+  ADDRESS_LINE_3,

[Evan Stade, 2014/06/12 01:49:47]

is it correct to put this at the end or can it go by its brethren?

[Ilya Sherman, 2014/06/12 22:37:54]

This is correct.  Alternately, we could rename the metric and reorder the fields
so that line 3 is in the middle.

Note that when making changes to metrics, you should also update histograms.xml.

[Evan Stade, 2014/06/13 01:49:43]

wouldn't that make it harder to compare across chrome versions?
Done.

[Ilya Sherman, 2014/06/13 21:50:09]

Aye, I think adding it at the end, as you've done, is the better option.

   NUM_FIELD_TYPE_GROUPS_FOR_METRICS
 };
 
@@ -87,6 +88,9 @@ int GetFieldTypeGroupMetric(const ServerFieldType field_type,
         case ADDRESS_HOME_LINE2:
           group = ADDRESS_LINE_2;
           break;
+        case ADDRESS_HOME_LINE3:
+          group = ADDRESS_LINE_3;
+          break;
         case ADDRESS_HOME_CITY:
           group = ADDRESS_CITY;
           break;