autocomplete: support address-line3, address-level{1,2,3}

components/autofill/core/browser/autofill_metrics.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/time/time.h"
@@ skipping 16 matching lines @@
   ADDRESS_ZIP,
   ADDRESS_COUNTRY,
   PHONE,
   FAX,  // Deprecated.
   EMAIL,
   CREDIT_CARD_NAME,
   CREDIT_CARD_NUMBER,
   CREDIT_CARD_DATE,
   CREDIT_CARD_TYPE,
   PASSWORD,
+  ADDRESS_LINE_3,

[Evan Stade, 2014/06/12 01:49:47]

is it correct to put this at the end or can it go by its brethren?

[Ilya Sherman, 2014/06/12 22:37:54]

This is correct.  Alternately, we could rename the metric and reorder the fields
so that line 3 is in the middle.

Note that when making changes to metrics, you should also update histograms.xml.

[Evan Stade, 2014/06/13 01:49:43]

wouldn't that make it harder to compare across chrome versions?
Done.

[Ilya Sherman, 2014/06/13 21:50:09]

Aye, I think adding it at the end, as you've done, is the better option.

   NUM_FIELD_TYPE_GROUPS_FOR_METRICS
 };
 
 // First, translates |field_type| to the corresponding logical |group| from
 // |FieldTypeGroupForMetrics|.  Then, interpolates this with the given |metric|,
 // which should be in the range [0, |num_possible_metrics|).
 // Returns the interpolated index.
 //
 // The interpolation maps the pair (|group|, |metric|) to a single index, so
 // that all the indicies for a given group are adjacent.  In particular, with
@@ skipping 33 matching lines @@
 
     case ::autofill::ADDRESS_HOME:
     case ::autofill::ADDRESS_BILLING:
       switch (AutofillType(field_type).GetStorableType()) {
         case ADDRESS_HOME_LINE1:
           group = ADDRESS_LINE_1;
           break;
         case ADDRESS_HOME_LINE2:
           group = ADDRESS_LINE_2;
           break;
+        case ADDRESS_HOME_LINE3:
+          group = ADDRESS_LINE_3;
+          break;
         case ADDRESS_HOME_CITY:
           group = ADDRESS_CITY;
           break;
         case ADDRESS_HOME_STATE:
           group = ADDRESS_STATE;
           break;
         case ADDRESS_HOME_ZIP:
           group = ADDRESS_ZIP;
           break;
         case ADDRESS_HOME_COUNTRY:
@@ skipping 330 matching lines @@
 
 void AutofillMetrics::LogStoredProfileCount(size_t num_profiles) const {
   UMA_HISTOGRAM_COUNTS("Autofill.StoredProfileCount", num_profiles);
 }
 
 void AutofillMetrics::LogAddressSuggestionsCount(size_t num_suggestions) const {
   UMA_HISTOGRAM_COUNTS("Autofill.AddressSuggestionsCount", num_suggestions);
 }
 
 }  // namespace autofill