Issue 322253006: Password bubble: Add an "active" icon state, and a new disabled icon.

Issue 322253006: Password bubble: Add an "active" icon state, and a new disabled icon. (Closed)

Created:
6 years, 6 months ago by Mike West

Modified:
6 years, 6 months ago

Reviewers:
vabr (Chromium), oshima

CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Password bubble: Add an "active" icon state, and a new disabled icon. ------------------------------------------------------------------------ This is a re-land of r276284, which was reverted due to test breakage. The original review is https://codereview.chromium.org/324853004/ ------------------------------------------------------------------------ BUG=261628 TBR=oshima@chromium.org, vabr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276311

Patch Set 1 #

Patch Set 2 : 500s. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -18 lines)			Patch
D	chrome/app/theme/default_100_percent/common/blocked_save_passwords.png	View	Binary file		0 comments	Download
D	chrome/app/theme/default_100_percent/common/save_password.png	View	Binary file		0 comments	Download
A	chrome/app/theme/default_100_percent/common/save_password_active.png	View	Binary file		0 comments	Download
A	chrome/app/theme/default_100_percent/common/save_password_disabled_active.png	View	Binary file		0 comments	Download
A	chrome/app/theme/default_100_percent/common/save_password_disabled_inactive.png	View	Binary file		0 comments	Download
A	chrome/app/theme/default_100_percent/common/save_password_inactive.png	View	Binary file		0 comments	Download
D	chrome/app/theme/default_200_percent/common/blocked_save_passwords.png	View	Binary file		0 comments	Download
D	chrome/app/theme/default_200_percent/common/save_password.png	View	Binary file		0 comments	Download
A	chrome/app/theme/default_200_percent/common/save_password_active.png	View	Binary file		0 comments	Download
A	chrome/app/theme/default_200_percent/common/save_password_disabled_active.png	View	Binary file		0 comments	Download
A	chrome/app/theme/default_200_percent/common/save_password_disabled_inactive.png	View	Binary file		0 comments	Download
A	chrome/app/theme/default_200_percent/common/save_password_inactive.png	View	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_icon.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_icon.cc	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_ui_controller.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc	View	3 chunks	+13 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc	View	1 chunk	+18 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike West

Committed patchset #2 manually as r276311 (presubmit successful).

6 years, 6 months ago (2014-06-11 09:03:41 UTC) #1

Mike West

On 2014/06/11 09:03:41, Mike West wrote: > Committed patchset #2 manually as r276311 (presubmit successful). ...

6 years, 6 months ago (2014-06-11 09:47:34 UTC) #2

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages