Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc

Issue 322253006: Password bubble: Add an "active" icon state, and a new disabled icon. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 500s. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc
index 9f1331c87f14eeb1f2a60a291f18826d7967c985..4338aaaef30f4e2c7fdde9976669827ab19c82ce 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc
@@ -19,28 +19,43 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsIconViewTest, DefaultStateIsInactive) {
EXPECT_FALSE(view()->visible());
EXPECT_EQ(0, view()->icon_id());
EXPECT_EQ(0, view()->tooltip_text_id());
+ view()->SetActive(true);
+ EXPECT_EQ(0, view()->icon_id());
+ view()->SetActive(false);
+ EXPECT_EQ(0, view()->icon_id());
}
IN_PROC_BROWSER_TEST_F(ManagePasswordsIconViewTest, PendingState) {
SetupPendingPassword();
EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_STATE, view()->state());
EXPECT_TRUE(view()->visible());
- EXPECT_EQ(IDR_SAVE_PASSWORD, view()->icon_id());
+ EXPECT_TRUE(view()->active());
+ EXPECT_EQ(IDR_SAVE_PASSWORD_ACTIVE, view()->icon_id());
EXPECT_EQ(IDS_PASSWORD_MANAGER_TOOLTIP_SAVE, view()->tooltip_text_id());
+ view()->SetActive(false);
+ EXPECT_EQ(IDR_SAVE_PASSWORD_INACTIVE, view()->icon_id());
}
IN_PROC_BROWSER_TEST_F(ManagePasswordsIconViewTest, ManageState) {
SetupManagingPasswords();
EXPECT_EQ(password_manager::ui::MANAGE_STATE, view()->state());
EXPECT_TRUE(view()->visible());
- EXPECT_EQ(IDR_SAVE_PASSWORD, view()->icon_id());
+ EXPECT_EQ(IDR_SAVE_PASSWORD_INACTIVE, view()->icon_id());
EXPECT_EQ(IDS_PASSWORD_MANAGER_TOOLTIP_MANAGE, view()->tooltip_text_id());
+ view()->SetActive(true);
+ EXPECT_EQ(IDR_SAVE_PASSWORD_ACTIVE, view()->icon_id());
+ view()->SetActive(false);
+ EXPECT_EQ(IDR_SAVE_PASSWORD_INACTIVE, view()->icon_id());
}
IN_PROC_BROWSER_TEST_F(ManagePasswordsIconViewTest, BlacklistedState) {
SetupBlackistedPassword();
EXPECT_EQ(password_manager::ui::BLACKLIST_STATE, view()->state());
EXPECT_TRUE(view()->visible());
- EXPECT_EQ(IDR_SAVE_PASSWORD_BLACKLISTED, view()->icon_id());
+ EXPECT_EQ(IDR_SAVE_PASSWORD_DISABLED_INACTIVE, view()->icon_id());
EXPECT_EQ(IDS_PASSWORD_MANAGER_TOOLTIP_MANAGE, view()->tooltip_text_id());
+ view()->SetActive(true);
+ EXPECT_EQ(IDR_SAVE_PASSWORD_DISABLED_ACTIVE, view()->icon_id());
+ view()->SetActive(false);
+ EXPECT_EQ(IDR_SAVE_PASSWORD_DISABLED_INACTIVE, view()->icon_id());
}
« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698