Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 32213003: [Android] MediaPlayerBridge should pass Bridge to getAllowedOperations (Closed)

Created:
7 years, 2 months ago by benm (inactive)
Modified:
7 years, 2 months ago
Reviewers:
bulach, qinmin, Min Qin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] MediaPlayerBridge should pass Bridge to getAllowedOperations Right now the Java side is expecting a MediaPlayer object to be passed to the MediaPlayerBridge.getAllowedOperations function, but native is actually passing it a MediaPlayerBridge. Update the code to be consistent - Java now expects the MediaPlayerBrdige and uses it to extract a MediaPlayer. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/base/android/java/src/org/chromium/media/MediaPlayerBridge.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
benm (inactive)
ptal!
7 years, 2 months ago (2013-10-21 11:29:32 UTC) #1
bulach
lgtm, I wished there was some way to catch this at build time..
7 years, 2 months ago (2013-10-21 13:00:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/32213003/1
7 years, 2 months ago (2013-10-21 13:20:59 UTC) #3
commit-bot: I haz the power
Change committed as 229826
7 years, 2 months ago (2013-10-21 16:21:12 UTC) #4
joth
On 2013/10/21 13:00:26, bulach wrote: > lgtm, I wished there was some way to catch ...
7 years, 2 months ago (2013-10-21 18:36:54 UTC) #5
qinmin
7 years, 2 months ago (2013-10-21 20:04:06 UTC) #6
Message was sent while issue was closed.
unit test is probably ok, we need to inject a java mediaplayer into the
MediaPlayerBridge.
i am not sure how to write a browser test for this, since it seems to me it will
involve cast to make this happen.

Powered by Google App Engine
This is Rietveld 408576698