Issue 322006: BookmarkManager keyboard shortcuts were broken

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322006: BookmarkManager keyboard shortcuts were broken (Closed)

Created:
11 years, 2 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The TableViewObserver::OnKeyDown method signature was changed recently and the bookmark manager view had not been properly updated and was not called anymore, breaking the keyboard shortcuts. This was broken in the TaskManager as well. Also changed the TreeView to use the base::KeyboardCode. BUG=25533 TEST=Test that the different shortcuts (CTRL-X,CTRL-V, CTRL-C, DELETE, ENTER...) work in the bookmark manager. Test that in the TaskManager, pressing ENTER activates the selected tab. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29854

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -23 lines)			Patch
M	chrome/browser/views/bookmark_manager_view.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/views/bookmark_manager_view.cc	View	6 chunks	+16 lines, -16 lines	0 comments	Download
M	chrome/browser/views/task_manager_view.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	views/controls/table/table_view_observer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/controls/tree/tree_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/tree/tree_view.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages