Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Side by Side Diff: chrome/browser/views/bookmark_manager_view.h

Issue 322006: BookmarkManager keyboard shortcuts were broken (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/views/bookmark_manager_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_VIEWS_BOOKMARK_MANAGER_VIEW_H_ 5 #ifndef CHROME_BROWSER_VIEWS_BOOKMARK_MANAGER_VIEW_H_
6 #define CHROME_BROWSER_VIEWS_BOOKMARK_MANAGER_VIEW_H_ 6 #define CHROME_BROWSER_VIEWS_BOOKMARK_MANAGER_VIEW_H_
7 7
8 #include "base/keyboard_codes.h"
8 #include "base/ref_counted.h" 9 #include "base/ref_counted.h"
9 #include "base/task.h" 10 #include "base/task.h"
10 #include "chrome/browser/bookmarks/bookmark_model_observer.h" 11 #include "chrome/browser/bookmarks/bookmark_model_observer.h"
11 #include "chrome/browser/shell_dialogs.h" 12 #include "chrome/browser/shell_dialogs.h"
12 #include "chrome/browser/sync/profile_sync_service.h" 13 #include "chrome/browser/sync/profile_sync_service.h"
13 #include "chrome/browser/views/bookmark_context_menu.h" 14 #include "chrome/browser/views/bookmark_context_menu.h"
14 #include "views/controls/button/text_button.h" 15 #include "views/controls/button/text_button.h"
15 #include "views/controls/menu/view_menu_delegate.h" 16 #include "views/controls/menu/view_menu_delegate.h"
16 #include "views/controls/table/table_view_observer.h" 17 #include "views/controls/table/table_view_observer.h"
17 #include "views/controls/textfield/textfield.h" 18 #include "views/controls/textfield/textfield.h"
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 // View methods. 106 // View methods.
106 virtual bool AcceleratorPressed(const views::Accelerator& accelerator); 107 virtual bool AcceleratorPressed(const views::Accelerator& accelerator);
107 108
108 private: 109 private:
109 // TableViewObserver methods. 110 // TableViewObserver methods.
110 virtual void OnSelectionChanged() {} 111 virtual void OnSelectionChanged() {}
111 // Overriden to open the selected table nodes in the current browser. 112 // Overriden to open the selected table nodes in the current browser.
112 virtual void OnDoubleClick(); 113 virtual void OnDoubleClick();
113 virtual void OnMiddleClick(); 114 virtual void OnMiddleClick();
114 virtual void OnTableViewDelete(views::TableView* table); 115 virtual void OnTableViewDelete(views::TableView* table);
115 virtual void OnKeyDown(unsigned short virtual_keycode); 116 virtual void OnKeyDown(base::KeyboardCode keycode);
116 117
117 // TreeViewController methods. 118 // TreeViewController methods.
118 virtual void OnTreeViewSelectionChanged(views::TreeView* tree_view); 119 virtual void OnTreeViewSelectionChanged(views::TreeView* tree_view);
119 virtual void OnTreeViewKeyDown(unsigned short virtual_keycode); 120 virtual void OnTreeViewKeyDown(base::KeyboardCode keycode);
120 121
121 #if defined(BROWSER_SYNC) 122 #if defined(BROWSER_SYNC)
122 // views::ButtonListener method. 123 // views::ButtonListener method.
123 virtual void ButtonPressed(views::Button* sender, const views::Event& event); 124 virtual void ButtonPressed(views::Button* sender, const views::Event& event);
124 #endif 125 #endif
125 126
126 // BookmarkModelObserver. We're only installed as an observer until the 127 // BookmarkModelObserver. We're only installed as an observer until the
127 // bookmarks are loaded. 128 // bookmarks are loaded.
128 virtual void Loaded(BookmarkModel* model); 129 virtual void Loaded(BookmarkModel* model);
129 virtual void BookmarkModelBeingDeleted(BookmarkModel* model) {} 130 virtual void BookmarkModelBeingDeleted(BookmarkModel* model) {}
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 ProfileSyncService* sync_service_; 239 ProfileSyncService* sync_service_;
239 #endif 240 #endif
240 241
241 // Factory used for delaying search. 242 // Factory used for delaying search.
242 ScopedRunnableMethodFactory<BookmarkManagerView> search_factory_; 243 ScopedRunnableMethodFactory<BookmarkManagerView> search_factory_;
243 244
244 DISALLOW_COPY_AND_ASSIGN(BookmarkManagerView); 245 DISALLOW_COPY_AND_ASSIGN(BookmarkManagerView);
245 }; 246 };
246 247
247 #endif // CHROME_BROWSER_VIEWS_BOOKMARK_MANAGER_VIEW_H_ 248 #endif // CHROME_BROWSER_VIEWS_BOOKMARK_MANAGER_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/views/bookmark_manager_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698