Chromium Code Reviews| Index: mojo/public/cpp/bindings/lib/router.h |
| diff --git a/mojo/public/cpp/bindings/lib/router.h b/mojo/public/cpp/bindings/lib/router.h |
| index 4a487d7f67d63829f3e6f4f49e38e3ec50d206dd..352bb56daed4aff0e0363283cd877364946fc534 100644 |
| --- a/mojo/public/cpp/bindings/lib/router.h |
| +++ b/mojo/public/cpp/bindings/lib/router.h |
| @@ -33,13 +33,6 @@ class Router : public MessageReceiverWithResponder { |
| connector_.set_error_handler(error_handler); |
| } |
| - // Errors from incoming receivers will force the router's connector into an |
| - // error state, where no more messages will be processed. This method is used |
| - // during testing to prevent that from happening. |
| - void set_enforce_errors_from_incoming_receiver(bool enforce) { |
| - connector_.set_enforce_errors_from_incoming_receiver(enforce); |
| - } |
| - |
| // Returns true if an error was encountered while reading from the pipe or |
| // waiting to read from the pipe. |
| bool encountered_error() const { return connector_.encountered_error(); } |
| @@ -57,6 +50,13 @@ class Router : public MessageReceiverWithResponder { |
| virtual bool AcceptWithResponder(Message* message, MessageReceiver* responder) |
| MOJO_OVERRIDE; |
| + // Sets this object to testing mode. |
| + // In testing mode: |
| + // - the object is more tolerant of unrecognized response messages; |
| + // - the connector continues working after seeing errors from its incoming |
| + // receiver. |
| + void EnableTestingMode(); |
|
darin (slow to review)
2014/06/12 23:06:56
another idea is to call this permissive mode. that
yzshen1
2014/06/12 23:12:21
I think if it is currently only useful for testing
|
| + |
| private: |
| typedef std::map<uint64_t, MessageReceiver*> ResponderMap; |
| @@ -81,6 +81,7 @@ class Router : public MessageReceiverWithResponder { |
| MessageReceiverWithResponder* incoming_receiver_; |
| ResponderMap responders_; |
| uint64_t next_request_id_; |
| + bool testing_mode_; |
| }; |
| } // namespace internal |