Mojo message validation tests: add integration tests and move existing conformance tests.

mojo/public/cpp/bindings/lib/router.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_BINDINGS_LIB_ROUTER_H_
 #define MOJO_PUBLIC_CPP_BINDINGS_LIB_ROUTER_H_
 
 #include <map>
 
 #include "mojo/public/cpp/bindings/lib/connector.h"
@@ skipping 15 matching lines @@
   void set_incoming_receiver(MessageReceiverWithResponder* receiver) {
     incoming_receiver_ = receiver;
   }
 
   // Sets the error handler to receive notifications when an error is
   // encountered while reading from the pipe or waiting to read from the pipe.
   void set_error_handler(ErrorHandler* error_handler) {
     connector_.set_error_handler(error_handler);
   }
 
-  // Errors from incoming receivers will force the router's connector into an
-  // error state, where no more messages will be processed. This method is used
-  // during testing to prevent that from happening.
-  void set_enforce_errors_from_incoming_receiver(bool enforce) {
-    connector_.set_enforce_errors_from_incoming_receiver(enforce);
-  }
-
   // Returns true if an error was encountered while reading from the pipe or
   // waiting to read from the pipe.
   bool encountered_error() const { return connector_.encountered_error(); }
 
   void CloseMessagePipe() {
     connector_.CloseMessagePipe();
   }
 
   ScopedMessagePipeHandle PassMessagePipe() {
     return connector_.PassMessagePipe();
   }
 
   // MessageReceiver implementation:
   virtual bool Accept(Message* message) MOJO_OVERRIDE;
   virtual bool AcceptWithResponder(Message* message, MessageReceiver* responder)
       MOJO_OVERRIDE;
 
+  // Sets this object to testing mode.
+  // In testing mode:
+  // - the object is more tolerant of unrecognized response messages;
+  // - the connector continues working after seeing errors from its incoming
+  //   receiver.
+  void EnableTestingMode();

[darin (slow to review), 2014/06/12 23:06:56]

another idea is to call this permissive mode. that may be nice if this mode
could be useful outside of testing.

[yzshen1, 2014/06/12 23:12:21]

I think if it is currently only useful for testing, it is good to explicitly say
so in the name, in case people mistakenly use it.

If later we have a non-testing use case, we could rename then. (Or maybe you
already have such use cases in mind?)

What do you think? Thanks!

+
  private:
   typedef std::map<uint64_t, MessageReceiver*> ResponderMap;
 
   class HandleIncomingMessageThunk : public MessageReceiver {
    public:
     HandleIncomingMessageThunk(Router* router);
     virtual ~HandleIncomingMessageThunk();
 
     // MessageReceiver implementation:
     virtual bool Accept(Message* message) MOJO_OVERRIDE;
 
    private:
     Router* router_;
   };
 
   bool HandleIncomingMessage(Message* message);
 
   HandleIncomingMessageThunk thunk_;
   FilterChain filters_;
   Connector connector_;
   SharedData<Router*> weak_self_;
   MessageReceiverWithResponder* incoming_receiver_;
   ResponderMap responders_;
   uint64_t next_request_id_;
+  bool testing_mode_;
 };
 
 }  // namespace internal
 }  // namespace mojo
 
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_LIB_ROUTER_H_