Mojo message validation tests: add integration tests and move existing conformance tests.

Mojo message validation tests: add integration tests and move existing conformance tests.

More conformance tests will come in a separate CL.

BUG=None
TEST=ValidationTest.*; ValidationIntegrationTest.*
R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277334

[yzshen1, 2014-06-10 03:25:10]

Hi, Darin.

Would you please take a look? Thanks!

[yzshen1, 2014-06-12 23:02:05]

On 2014/06/10 03:25:10, yzshen1 wrote:
> Hi, Darin.
> 
> Would you please take a look? Thanks!

Friendly ping, Darin.

[darin (slow to review), 2014-06-12 23:06:56]

LGTM

https://codereview.chromium.org/322003002/diff/40001/mojo/public/cpp/bindings...
File mojo/public/cpp/bindings/lib/router.h (right):

https://codereview.chromium.org/322003002/diff/40001/mojo/public/cpp/bindings...
mojo/public/cpp/bindings/lib/router.h:58: void EnableTestingMode();
another idea is to call this permissive mode. that may be nice if this mode
could be useful outside of testing.

https://codereview.chromium.org/322003002/diff/40001/mojo/public/cpp/bindings...
File mojo/public/cpp/bindings/tests/validation_unittest.cc (right):

https://codereview.chromium.org/322003002/diff/40001/mojo/public/cpp/bindings...
mojo/public/cpp/bindings/tests/validation_unittest.cc:222: 
nit: nuke extra newline

[yzshen1, 2014-06-12 23:12:21]

Thanks Darin!

https://codereview.chromium.org/322003002/diff/40001/mojo/public/cpp/bindings...
File mojo/public/cpp/bindings/lib/router.h (right):

https://codereview.chromium.org/322003002/diff/40001/mojo/public/cpp/bindings...
mojo/public/cpp/bindings/lib/router.h:58: void EnableTestingMode();
On 2014/06/12 23:06:56, darin wrote:
> another idea is to call this permissive mode. that may be nice if this mode
> could be useful outside of testing.

I think if it is currently only useful for testing, it is good to explicitly say
so in the name, in case people mistakenly use it.

If later we have a non-testing use case, we could rename then. (Or maybe you
already have such use cases in mind?)

What do you think? Thanks!

https://codereview.chromium.org/322003002/diff/40001/mojo/public/cpp/bindings...
File mojo/public/cpp/bindings/tests/validation_unittest.cc (right):

https://codereview.chromium.org/322003002/diff/40001/mojo/public/cpp/bindings...
mojo/public/cpp/bindings/tests/validation_unittest.cc:222: 
On 2014/06/12 23:06:56, darin wrote:
> nit: nuke extra newline

Done.

[yzshen1, 2014-06-12 23:18:51]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2014-06-12 23:23:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yzshen@chromium.org/322003002/60001

[commit-bot: I haz the power, 2014-06-13 08:00:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-13 08:05:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 08:05:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[yzshen1, 2014-06-15 18:38:28]

Committed patchset #6 manually as r277334.