Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: pylib/gyp/xcode_emulation.py

Issue 32193007: [ninja/mac] Add xcode_emulation support for -Wobjc-missing-property-synthesis. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/ios/app-bundle/TestApp/ViewController.mm » ('j') | test/ios/app-bundle/test-error.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/xcode_emulation.py
===================================================================
--- pylib/gyp/xcode_emulation.py (revision 1767)
+++ pylib/gyp/xcode_emulation.py (working copy)
@@ -317,6 +317,10 @@
if self._Test('CLANG_WARN_CONSTANT_CONVERSION', 'YES', default='NO'):
cflags.append('-Wconstant-conversion')
+ if self._Test('CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS',
+ 'YES', default='NO'):
+ cflags.append('-Wobjc-missing-property-synthesis')
Nico 2013/10/22 21:52:12 Is this set for .c and .cc files too?
justincohen 2013/10/22 21:53:44 It's just an objc thing, m/mm, am I setting it inc
Nico 2013/10/22 21:56:49 I don't think so as you're adding it to all cflags
justincohen 2013/10/23 01:58:14 I added the c and cc files but I see no warnings.
+
if self._Test('GCC_CHAR_IS_UNSIGNED_CHAR', 'YES', default='NO'):
cflags.append('-funsigned-char')
« no previous file with comments | « no previous file | test/ios/app-bundle/TestApp/ViewController.mm » ('j') | test/ios/app-bundle/test-error.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698