[ninja/mac] Add xcode_emulation support for -Wobjc-missing-property-synthesis.

pylib/gyp/xcode_emulation.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 This module contains classes that help to emulate xcodebuild behavior on top of
 other build systems, such as make and ninja.
 """
 
 import copy
@@ skipping 299 matching lines @@
     self.configname = configname
     cflags = []
 
     sdk_root = self._SdkPath()
     if 'SDKROOT' in self._Settings():
       cflags.append('-isysroot %s' % sdk_root)
 
     if self._Test('CLANG_WARN_CONSTANT_CONVERSION', 'YES', default='NO'):
       cflags.append('-Wconstant-conversion')
 
+    if self._Test('CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS',
+                  'YES', default='NO'):
+      cflags.append('-Wobjc-missing-property-synthesis')

[Nico, 2013/10/22 21:52:12]

Is this set for .c and .cc files too?

[justincohen, 2013/10/22 21:53:44]

It's just an objc thing, m/mm, am I setting it incorrectly?

On 2013/10/22 21:52:12, Nico wrote:

[Nico, 2013/10/22 21:56:49]

I don't think so as you're adding it to all cflags. If you add a c and a cc
file, clang might tell you 'warning unused for this source type' (or it might
not). I'd add it to GetCflagsObjC / GetCflagsObjCC below

[justincohen, 2013/10/23 01:58:14]

I added the c and cc files but I see no warnings.  I moved it to CflagsObC/CC.

On 2013/10/22 21:56:49, Nico wrote:

+
     if self._Test('GCC_CHAR_IS_UNSIGNED_CHAR', 'YES', default='NO'):
       cflags.append('-funsigned-char')
 
     if self._Test('GCC_CW_ASM_SYNTAX', 'YES', default='YES'):
       cflags.append('-fasm-blocks')
 
     if 'GCC_DYNAMIC_NO_PIC' in self._Settings():
       if self._Settings()['GCC_DYNAMIC_NO_PIC'] == 'YES':
         cflags.append('-mdynamic-no-pic')
     else:
@@ skipping 960 matching lines @@
         new_config_dict['xcode_settings']['SDKROOT'] = 'iphoneos'
       target_dict['configurations'][new_config_name] = new_config_dict
   return targets
 
 def CloneConfigurationForDeviceAndEmulator(target_dicts):
   """If |target_dicts| contains any iOS targets, automatically create -iphoneos
   targets for iOS device builds."""
   if _HasIOSTarget(target_dicts):
     return _AddIOSDeviceConfigurations(target_dicts)
   return target_dicts