[ninja/mac] Add xcode_emulation support for -Wobjc-missing-property-synthesis.

[ninja/mac] Add xcode_emulation support for -Wobjc-missing-property-synthesis.

CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS maps to
-Wobjc-missing-property-synthesis

R=thakis@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1768

[justincohen, 2013-10-22 21:37:47]

PTAL!

[Nico, 2013-10-22 21:52:12]

https://codereview.chromium.org/32193007/diff/50001/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/32193007/diff/50001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:322:
cflags.append('-Wobjc-missing-property-synthesis')
Is this set for .c and .cc files too?

https://codereview.chromium.org/32193007/diff/50001/test/ios/app-bundle/test-...
File test/ios/app-bundle/test-error.gyp (right):

https://codereview.chromium.org/32193007/diff/50001/test/ios/app-bundle/test-...
test/ios/app-bundle/test-error.gyp:22: 'TestApp/ViewController.mm',
Please add a c and a cc file too (can be empty)

[justincohen, 2013-10-22 21:53:44]

https://codereview.chromium.org/32193007/diff/50001/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/32193007/diff/50001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:322:
cflags.append('-Wobjc-missing-property-synthesis')
It's just an objc thing, m/mm, am I setting it incorrectly?

On 2013/10/22 21:52:12, Nico wrote:
> Is this set for .c and .cc files too?

[Nico, 2013-10-22 21:56:48]

https://codereview.chromium.org/32193007/diff/50001/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/32193007/diff/50001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:322:
cflags.append('-Wobjc-missing-property-synthesis')
On 2013/10/22 21:53:44, justincohen wrote:
> It's just an objc thing, m/mm, am I setting it incorrectly?

I don't think so as you're adding it to all cflags. If you add a c and a cc
file, clang might tell you 'warning unused for this source type' (or it might
not). I'd add it to GetCflagsObjC / GetCflagsObjCC below
> 
> On 2013/10/22 21:52:12, Nico wrote:
> > Is this set for .c and .cc files too?
>

[justincohen, 2013-10-23 01:58:14]

https://codereview.chromium.org/32193007/diff/50001/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/32193007/diff/50001/pylib/gyp/xcode_emulation...
pylib/gyp/xcode_emulation.py:322:
cflags.append('-Wobjc-missing-property-synthesis')
I added the c and cc files but I see no warnings.  I moved it to CflagsObC/CC.

On 2013/10/22 21:56:49, Nico wrote:
> On 2013/10/22 21:53:44, justincohen wrote:
> > It's just an objc thing, m/mm, am I setting it incorrectly?
> 
> I don't think so as you're adding it to all cflags. If you add a c and a cc
> file, clang might tell you 'warning unused for this source type' (or it might
> not). I'd add it to GetCflagsObjC / GetCflagsObjCC below
> > 
> > On 2013/10/22 21:52:12, Nico wrote:
> > > Is this set for .c and .cc files too?
> > 
>

https://codereview.chromium.org/32193007/diff/50001/test/ios/app-bundle/test-...
File test/ios/app-bundle/test-error.gyp (right):

https://codereview.chromium.org/32193007/diff/50001/test/ios/app-bundle/test-...
test/ios/app-bundle/test-error.gyp:22: 'TestApp/ViewController.mm',
On 2013/10/22 21:52:12, Nico wrote:
> Please add a c and a cc file too (can be empty)

Done.

[Nico, 2013-10-23 02:03:08]

/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python
test/ios/gyptest-app-error-ios.py
FAILED test at line 423 of
/Volumes/data/b/build/slave/gyp/build/trunk/test/lib/TestCommon.py (_complete)
	from line 532 of
/Volumes/data/b/build/slave/gyp/build/trunk/test/lib/TestCommon.py (run)
	from line 272 of
/Volumes/data/b/build/slave/gyp/build/trunk/test/lib/TestGyp.py (run)
	from line 736 of
/Volumes/data/b/build/slave/gyp/build/trunk/test/lib/TestGyp.py (build)
	from line 23 of test/ios/gyptest-app-error-ios.py
None returned 1
STDOUT =========================================================================
ninja: Entering directory `out/Default'

STDERR =========================================================================
ninja: error: '../../TestApp/empty_c.c', needed by
'obj/TestApp/test_app.empty_c.o', missing and no known rule to make it

[justincohen, 2013-10-23 02:27:07]

Is it possible both xcode and ninja are too old to support this warning? 
Xcode-clang is ignoring it, and ninja-clang shows:
warning: unknown warning option '-Wobjc-missing-property-synthesis'
[-Wunknown-warning-option]

[Nico, 2013-10-23 03:06:53]

Don't land the test :-( Keep it around, we'll upgrade the bots eventually.

lgtm

[justincohen, 2013-10-23 13:23:18]

Committed patchset #11 manually as r1768 (presubmit successful).