Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 321913002: Removed un-used commandline switches. (Closed)

Created:
6 years, 6 months ago by Zhenyao Mo
Modified:
6 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, binji+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Visibility:
Public.

Description

Removed un-used commandline switches. --disable-gl-multisampling (replaced by gpu_driver_bug_workaround switch --disable_multisampling) --enable-chromium-branding (no longer used) --force_discrete (no longer used, use gpu_driver_bug_workaround instead) --force_integrated (no longer used, use gpu_driver_bug_workaround instead) --gpu-switching (no longer used, use gpu_driver_bug_workaround instead) BUG=351312 TEST=bots R=kbr@chromium.org,piman@chromium.org,sky@chromium.org,nfullagar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277256

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -43 lines) Patch
M chrome/test/base/chrome_process_util.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M chrome/test/base/test_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/test_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/3D-graphics.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/coding/3D-graphics.rst View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_switches.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gl/gl_switches.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Zhenyao Mo
Please take a look. kbr: gpu related. piman: content/ owner sky: chrome/test/base owner nfullagar: native_client_sdk ...
6 years, 6 months ago (2014-06-09 20:39:39 UTC) #1
Zhenyao Mo
This is to remove myself from pkasting's harassment list. :)
6 years, 6 months ago (2014-06-09 20:40:27 UTC) #2
sky
LGTM
6 years, 6 months ago (2014-06-09 21:28:30 UTC) #3
binji
nfullagar is out sick today... native_client_sdk lgtm
6 years, 6 months ago (2014-06-09 21:55:10 UTC) #4
piman
lgtm
6 years, 6 months ago (2014-06-10 01:26:51 UTC) #5
Zhenyao Mo
kbr: ping
6 years, 6 months ago (2014-06-12 22:42:25 UTC) #6
Sam Clegg
https://codereview.chromium.org/321913002/diff/1/native_client_sdk/doc_generated/devguide/coding/3D-graphics.html File native_client_sdk/doc_generated/devguide/coding/3D-graphics.html (right): https://codereview.chromium.org/321913002/diff/1/native_client_sdk/doc_generated/devguide/coding/3D-graphics.html#newcode150 native_client_sdk/doc_generated/devguide/coding/3D-graphics.html:150: <li><code>--disable_multisampling</code></li> This seems inconsistent with the others.. has some ...
6 years, 6 months ago (2014-06-12 22:44:36 UTC) #7
Zhenyao Mo
On 2014/06/12 22:44:36, Sam Clegg wrote: > https://codereview.chromium.org/321913002/diff/1/native_client_sdk/doc_generated/devguide/coding/3D-graphics.html > File native_client_sdk/doc_generated/devguide/coding/3D-graphics.html (right): > > https://codereview.chromium.org/321913002/diff/1/native_client_sdk/doc_generated/devguide/coding/3D-graphics.html#newcode150 ...
6 years, 6 months ago (2014-06-12 22:46:08 UTC) #8
Ken Russell (switch to Gerrit)
lgtm
6 years, 6 months ago (2014-06-14 00:19:19 UTC) #9
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 6 months ago (2014-06-14 00:24:53 UTC) #10
Zhenyao Mo
The CQ bit was unchecked by zmo@chromium.org
6 years, 6 months ago (2014-06-14 00:26:39 UTC) #11
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 6 months ago (2014-06-14 00:27:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/321913002/20001
6 years, 6 months ago (2014-06-14 00:30:02 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 19:51:24 UTC) #14
Message was sent while issue was closed.
Change committed as 277256

Powered by Google App Engine
This is Rietveld 408576698