src/x64/debug-x64.cc - Issue 321743002: Reuse RelocInfo's IsPatchedDebugBreakSlotSequence() implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/debug-x64.cc

Issue 321743002: Reuse RelocInfo's IsPatchedDebugBreakSlotSequence() implementation. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/debug-x64.cc

diff --git a/src/x64/debug-x64.cc b/src/x64/debug-x64.cc

index bdb9e51202303a1beb72eb8858b62d31bc3378ea..4703e42354746586dfc2558173d0563089800493 100644

--- a/src/x64/debug-x64.cc

+++ b/src/x64/debug-x64.cc

@@ -48,7 +48,7 @@ bool Debug::IsDebugBreakAtReturn(v8::internal::RelocInfo* rinfo) {

bool BreakLocationIterator::IsDebugBreakAtSlot() {

ASSERT(IsDebugBreakSlot());

// Check whether the debug break slot instructions have been patched.

- return !Assembler::IsNop(rinfo()->pc());

+ return rinfo()->IsPatchedDebugBreakSlotSequence();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »