Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Side by Side Diff: src/x64/debug-x64.cc

Issue 321743002: Reuse RelocInfo's IsPatchedDebugBreakSlotSequence() implementation. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 30 matching lines...) Expand all
41 // having been patched with a call instruction. 41 // having been patched with a call instruction.
42 bool Debug::IsDebugBreakAtReturn(v8::internal::RelocInfo* rinfo) { 42 bool Debug::IsDebugBreakAtReturn(v8::internal::RelocInfo* rinfo) {
43 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode())); 43 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode()));
44 return rinfo->IsPatchedReturnSequence(); 44 return rinfo->IsPatchedReturnSequence();
45 } 45 }
46 46
47 47
48 bool BreakLocationIterator::IsDebugBreakAtSlot() { 48 bool BreakLocationIterator::IsDebugBreakAtSlot() {
49 ASSERT(IsDebugBreakSlot()); 49 ASSERT(IsDebugBreakSlot());
50 // Check whether the debug break slot instructions have been patched. 50 // Check whether the debug break slot instructions have been patched.
51 return !Assembler::IsNop(rinfo()->pc()); 51 return rinfo()->IsPatchedDebugBreakSlotSequence();
52 } 52 }
53 53
54 54
55 void BreakLocationIterator::SetDebugBreakAtSlot() { 55 void BreakLocationIterator::SetDebugBreakAtSlot() {
56 ASSERT(IsDebugBreakSlot()); 56 ASSERT(IsDebugBreakSlot());
57 rinfo()->PatchCodeWithCall( 57 rinfo()->PatchCodeWithCall(
58 debug_info_->GetIsolate()->builtins()->Slot_DebugBreak()->entry(), 58 debug_info_->GetIsolate()->builtins()->Slot_DebugBreak()->entry(),
59 Assembler::kDebugBreakSlotLength - Assembler::kCallSequenceLength); 59 Assembler::kDebugBreakSlotLength - Assembler::kCallSequenceLength);
60 } 60 }
61 61
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 __ jmp(rdx); 307 __ jmp(rdx);
308 } 308 }
309 309
310 const bool LiveEdit::kFrameDropperSupported = true; 310 const bool LiveEdit::kFrameDropperSupported = true;
311 311
312 #undef __ 312 #undef __
313 313
314 } } // namespace v8::internal 314 } } // namespace v8::internal
315 315
316 #endif // V8_TARGET_ARCH_X64 316 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698