Issue 321743002: Reuse RelocInfo's IsPatchedDebugBreakSlotSequence() implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 321743002: Reuse RelocInfo's IsPatchedDebugBreakSlotSequence() implementation. (Closed)

Created:
6 years, 6 months ago by tfarina

Modified:
6 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev, Toon Verwaest, jochen (gone - plz use gerrit)

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Reuse RelocInfo's IsPatchedDebugBreakSlotSequence() implementation. RelocInfo::IsPatchedDebugBreakSlotSequence() already does this assembly check, so just reuse it in BreakLocationIterator::IsDebugBreakAtSlot(), like the other debug ports do. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21734

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/x64/debug-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

6 years, 6 months ago (2014-06-10 09:16:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21734 (presubmit successful).

Expand Messages | Collapse Messages