test/NaCl/PNaClABI/abi-i1-operations.ll - Issue 321733002: PNaCl SIMD: allow element-aligned vector load/store

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/NaCl/PNaClABI/abi-i1-operations.ll

Issue 321733002: PNaCl SIMD: allow element-aligned vector load/store (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: Rebase. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/NaCl/PNaClABI/abi-i1-operations.ll

diff --git a/test/NaCl/PNaClABI/abi-i1-operations.ll b/test/NaCl/PNaClABI/abi-i1-operations.ll

index 21707298e325d6b1d0308503550e31d4bd483a09..14beda96bd7a92cd5a814829863305b13ffd98eb 100644

--- a/test/NaCl/PNaClABI/abi-i1-operations.ll

+++ b/test/NaCl/PNaClABI/abi-i1-operations.ll

@@ -33,12 +33,8 @@ define internal void @rejected_cases(i32 %ptr) {

; i1* as a pointer type.

%ptr.p = inttoptr i32 %ptr to i1*

; CHECK: disallowed: bad result type: i1* %ptr.p = inttoptr

- %vptr.p = inttoptr i32 %ptr to <4 x i1>*

-; CHECK: disallowed: bad result type: <4 x i1>* %vptr.p = inttoptr

jvoung (off chromium) 2014/06/10 16:28:32 I thought <N x i1> pointer were still disallowed?

JF 2014/06/10 18:26:29 Good catch. I started off by removing it, then for

load i1* %ptr.p, align 1

; CHECK-NEXT: disallowed: bad pointer: {{.*}} load i1*

- load <4 x i1>* %vptr.p, align 4

-; CHECK-NEXT: disallowed: bad pointer: {{.*}} load <4 x i1>*

; i1 arithmetic is of dubious usefulness, so it is rejected.

add i1 0, 0

« lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp ('K') | « test/NaCl/Bitcode/vector.ll ('k') | test/NaCl/PNaClABI/instructions.ll » ('j') | test/NaCl/PNaClABI/instructions.ll » ('J')