Mac: Fix a crash on "Look Up in Dictionary" context menu.

Mac: Fix a crash on "Look Up in Dictionary" context menu.
- Add [NSPasteboard declareTypes] invocation before [NSPasteboard setData],
  which is required on Loopard. (and not required SL.)
- Fixed a potential leak, using scoped_nsobject.

BUG=53519
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57841

[gmorrita, 2010-08-30 05:49:33]

Hi Nico, sorry for slow response. I've fixed a crash bug.
Could you take a look?

Landing this patch would much helpful because I'm not a committer yet and
the deadline is coming...

Regards.

[Nico, 2010-08-30 05:57:43]

http://codereview.chromium.org/3217006/diff/1/2
File chrome/browser/tab_contents/render_view_context_menu_mac.mm (right):

http://codereview.chromium.org/3217006/diff/1/2#newcode79
chrome/browser/tab_contents/render_view_context_menu_mac.mm:79:
scoped_nsobject<NSPasteboard> pboard([NSPasteboard pasteboardWithUniqueName]);
this is wrong, please google "create rule"

http://codereview.chromium.org/3217006/diff/1/2#newcode80
chrome/browser/tab_contents/render_view_context_menu_mac.mm:80: NSArray*
todeclare = [NSArray arrayWithObject:NSStringPboardType];
toDeclare

Can you point me to the docs that say this is required? (It looks right to me,
but it'd be nice to know where you got this knowledge from :-) )

[gmorrita, 2010-08-30 07:08:09]

> Can you point me to the docs that say this is required? (It looks right to me,
> but it'd be nice to know where you got this knowledge from :-) )
A box on
http://developer.apple.com/mac/library/documentation/Cocoa/Reference/Applicat...:
mentioned that.
There looks a chunk of change around pasteboard between 10.5 and 10.6.

http://codereview.chromium.org/3217006/diff/1/2
File chrome/browser/tab_contents/render_view_context_menu_mac.mm (right):

http://codereview.chromium.org/3217006/diff/1/2#newcode79
chrome/browser/tab_contents/render_view_context_menu_mac.mm:79:
scoped_nsobject<NSPasteboard> pboard([NSPasteboard pasteboardWithUniqueName]);
On 2010/08/30 05:57:43, Nico wrote:
> this is wrong, please google "create rule"

Done.

http://codereview.chromium.org/3217006/diff/1/2#newcode80
chrome/browser/tab_contents/render_view_context_menu_mac.mm:80: NSArray*
todeclare = [NSArray arrayWithObject:NSStringPboardType];
On 2010/08/30 05:57:43, Nico wrote:
> toDeclare
> 
> Can you point me to the docs that say this is required? (It looks right to me,
> but it'd be nice to know where you got this knowledge from :-) )

Done.

[Nico, 2010-08-30 07:28:35]

LG

Will land this in time for the m7 code freeze.

[gmorrita, 2010-08-30 07:37:36]

thanks!