Issue 321633002: Revert 275549 "Revert 275154 "ChromeOS login webui refactoring :..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 321633002: Revert 275549 "Revert 275154 "ChromeOS login webui refactoring :..." (Closed)

Created:
6 years, 6 months ago by pavely

Modified:
6 years, 6 months ago

Reviewers:
pavely

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 275549 "Revert 275154 "ChromeOS login webui refactoring :..." Tree doesn't compile, returning to original state. > Revert 275154 "ChromeOS login webui refactoring : Move GAIA-rela..." > > This change preventing me from reverting r275046 which seems to be causing > failures in KioskTest > http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > > > ChromeOS login webui refactoring : Move GAIA-related code to gaia_screen_handler > > > > BUG=373314 > > R=nkostylev@chromium.org > > > > Review URL: https://codereview.chromium.org/304303005 > > TBR=antrim@chromium.org > > Review URL: https://codereview.chromium.org/310313006 TBR=pavely@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275556

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+455 lines, -390 lines)			Patch
M	trunk/src/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h	View	3 chunks	+89 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc	View	6 chunks	+326 lines, -8 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h	View	10 chunks	+8 lines, -74 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View	24 chunks	+32 lines, -308 lines	0 comments	Download

Total messages: 2 (0 generated)

pavely

6 years, 6 months ago (2014-06-06 23:57:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r275556 (tree was closed).