Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 310313006: Revert 275154 "ChromeOS login webui refactoring : Move GAIA-rela..." (Closed)

Created:
6 years, 6 months ago by pavely
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 275154 "ChromeOS login webui refactoring : Move GAIA-rela..." This change preventing me from reverting r275046 which seems to be causing failures in KioskTest http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > ChromeOS login webui refactoring : Move GAIA-related code to gaia_screen_handler > > BUG=373314 > R=nkostylev@chromium.org > > Review URL: https://codereview.chromium.org/304303005 TBR=antrim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -455 lines) Patch
M trunk/src/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 3 chunks +0 lines, -89 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 6 chunks +8 lines, -326 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 10 chunks +74 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 24 chunks +308 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pavely
6 years, 6 months ago (2014-06-06 23:25:55 UTC) #1
pavely
6 years, 6 months ago (2014-06-06 23:26:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r275549 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698