Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/perf/page_sets/mobile_memory.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to head. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/media_cns_cases.py ('k') | tools/perf/page_sets/mse_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/mobile_memory.py
diff --git a/tools/perf/page_sets/mobile_memory.py b/tools/perf/page_sets/mobile_memory.py
index d04c659ba4f6bc8be538aa2392e7dcf5e2276b41..24bb72496fb5398931784fabbc6f1c66445ac966 100644
--- a/tools/perf/page_sets/mobile_memory.py
+++ b/tools/perf/page_sets/mobile_memory.py
@@ -31,10 +31,7 @@ class GmailPage(MobileMemoryPage):
def ReloadAndGc(self, action_runner):
action_runner.RunAction(ReloadAction())
- action_runner.RunAction(WaitAction(
- {
- 'seconds': 15
- }))
+ action_runner.Wait(15)
action_runner.RunAction(JsCollectGarbageAction())
def RunStressMemory(self, action_runner):
@@ -53,26 +50,14 @@ class GoogleSearchPage(MobileMemoryPage):
def RunStressMemory(self, action_runner):
action_runner.RunAction(ScrollAction())
- action_runner.RunAction(WaitAction(
- {
- 'seconds': 3
- }))
+ action_runner.Wait(3)
action_runner.RunAction(ScrollAction())
- action_runner.RunAction(WaitAction(
- {
- 'seconds': 3
- }))
+ action_runner.Wait(3)
action_runner.RunAction(ScrollAction())
- action_runner.RunAction(WaitAction(
- {
- 'seconds': 3
- }))
+ action_runner.Wait(3)
action_runner.RunAction(ScrollAction())
- action_runner.RunAction(WaitAction(
- {
- 'javascript':
- 'document.getElementById("rg_s").childElementCount > 300'
- }))
+ action_runner.WaitForJavaScriptCondition(
+ 'document.getElementById("rg_s").childElementCount > 300')
class ScrollPage(MobileMemoryPage):
« no previous file with comments | « tools/perf/page_sets/media_cns_cases.py ('k') | tools/perf/page_sets/mse_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698