tools/perf/page_sets/mse_cases.py - Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/mse_cases.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing to head. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/mse_cases.py

diff --git a/tools/perf/page_sets/mse_cases.py b/tools/perf/page_sets/mse_cases.py

index 6e2994e6df7ec8ae485fea02bb81eefbc6a38763..a71620c3ae524d4c35efa52859c9beef5622769f 100644

--- a/tools/perf/page_sets/mse_cases.py

+++ b/tools/perf/page_sets/mse_cases.py

@@ -14,10 +14,7 @@ class MseCasesPage(page_module.Page):

def RunNavigateSteps(self, action_runner):

action_runner.NavigateToPage(self)

- action_runner.RunAction(WaitAction(

- {

- 'javascript': 'window.__testDone == true'

- }))

+ action_runner.WaitForJavaScriptCondition('window.__testDone == true')

class MseCasesPageSet(page_set_module.PageSet):

« no previous file with comments | « tools/perf/page_sets/mobile_memory.py ('k') | tools/perf/page_sets/plus_alt_posts_photos.py » ('j') | no next file with comments »