Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 321463003: Revert 265329 "Add SM_CXSIZEFRAME and SM_CXPADDEDBORDER metrics ..." (Closed)

Created:
6 years, 6 months ago by jbauman
Modified:
6 years, 6 months ago
Reviewers:
jbauman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 265329 "Add SM_CXSIZEFRAME and SM_CXPADDEDBORDER metrics ..." This sometimes causes a few issues with multimonitor setups. Also, r274853 fixes it more thoroughly. > Add SM_CXSIZEFRAME and SM_CXPADDEDBORDER metrics to get window border size. > > Vista added the SM_CXPADDEDBORDER system metric which needs to be included > in the border size. The previous code happened to work with 32-bit Chrome > because Windows added the padding into SM_CXSIZEFRAME (and set the padding to 0) > for backwards compatibility, but with 64-bit that changed. > GetSystemMetrics(SM_CXPADDEDBORDER) should always return 0 on XP. > > BUG=361720 > > Review URL: https://codereview.chromium.org/243173005 BUG=361720, 379321 TBR=jbauman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M trunk/src/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/ui/views/win/hwnd_message_handler.cc View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jbauman
6 years, 6 months ago (2014-06-05 22:23:51 UTC) #1
jbauman
6 years, 6 months ago (2014-06-05 22:24:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r275261 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698